----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43207/#review117945 -----------------------------------------------------------
Ship it! As a fix, this seems fine. We should think about a centralized fix as proposed in the comments of the attached JIRA issue. - Till Toenshoff On Feb. 4, 2016, 11:17 p.m., Joseph Wu wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43207/ > ----------------------------------------------------------- > > (Updated Feb. 4, 2016, 11:17 p.m.) > > > Review request for mesos, Benjamin Hindman, Artem Harutyunyan, and Till > Toenshoff. > > > Bugs: MESOS-4598 > https://issues.apache.org/jira/browse/MESOS-4598 > > > Repository: mesos > > > Description > ------- > > Unsetting the `LIBPROCESS_IP` was originally unnecessary, as this variable > does not result in port conflicts. Unsetting this environment variable may > cause the subprocess to exit if DNS cannot resolve the agent's hostname. > > > Diffs > ----- > > src/slave/container_loggers/lib_logrotate.cpp > 8d2f89503cd8ace1971933006a46ed4d3936ff8e > > Diff: https://reviews.apache.org/r/43207/diff/ > > > Testing > ------- > > make check (OSX) > > > Thanks, > > Joseph Wu > >
