Re: Review Request 43371: Cleaned up docker Image::Name proto by ImageReference.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43371/#review119089 --- Ship it! Ship It! - Jie Yu On Feb. 12, 2016, 7:17 p.m., Gilbert Song wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43371/ > --- > > (Updated Feb. 12, 2016, 7:17 p.m.) > > > Review request for mesos and Jie Yu. > > > Repository: mesos > > > Description > --- > > Cleaned up docker Image::Name proto by ImageReference. > > > Diffs > - > > include/mesos/docker/spec.hpp 6033e824c6f776dc744caf11066b68d3629bb8ca > src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp > 7f441de097719114f81716caade44388720273f6 > src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp > abf6ddfcb1b8460fcac5c7c998d8be44ee712266 > src/slave/containerizer/mesos/provisioner/docker/message.hpp > 43c360862dbb7fa1b2d70825ffbdd5d6be689d93 > src/slave/containerizer/mesos/provisioner/docker/message.proto > 003c6661f1e2c687dd0ae22161435ef44cc5b5bd > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp > cb827bfd4d0519d663ebce62a4c4f4646af28a4c > src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp > bf85038f6a7e9940f9c410e7cf4ab50c2432673a > src/slave/containerizer/mesos/provisioner/docker/puller.hpp > d12b3d0ec9c1c7ce174451e4035e106eedcdcfd1 > src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp > bfe3086b738064e2957f7598dd3ca24ba1d59eca > src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp > 10c28f5617348745bcd22c00770a9ab08673bdf4 > src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp > 0c37e1fa5acf223eb731457cd12cfe7189f1e39c > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp > 623c54ee183298ef75060ee43397e7e9a5db3775 > src/slave/containerizer/mesos/provisioner/docker/store.cpp > 251973c84e5f792dfc89803db5e1796a86e770ba > src/tests/containerizer/provisioner_docker_tests.cpp > 4f77dcb9df59bbe1cd6561ef0c0102a5c9df027e > > Diff: https://reviews.apache.org/r/43371/diff/ > > > Testing > --- > > make check (ubuntu14.04 + clang-3.6) > > > Thanks, > > Gilbert Song > >
Re: Review Request 43371: Cleaned up docker Image::Name proto by ImageReference.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43371/ --- (Updated Feb. 12, 2016, 11:17 a.m.) Review request for mesos and Jie Yu. Changes --- Some little code adjustment. Repository: mesos Description --- Cleaned up docker Image::Name proto by ImageReference. Diffs (updated) - include/mesos/docker/spec.hpp 6033e824c6f776dc744caf11066b68d3629bb8ca src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 7f441de097719114f81716caade44388720273f6 src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp abf6ddfcb1b8460fcac5c7c998d8be44ee712266 src/slave/containerizer/mesos/provisioner/docker/message.hpp 43c360862dbb7fa1b2d70825ffbdd5d6be689d93 src/slave/containerizer/mesos/provisioner/docker/message.proto 003c6661f1e2c687dd0ae22161435ef44cc5b5bd src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp cb827bfd4d0519d663ebce62a4c4f4646af28a4c src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp bf85038f6a7e9940f9c410e7cf4ab50c2432673a src/slave/containerizer/mesos/provisioner/docker/puller.hpp d12b3d0ec9c1c7ce174451e4035e106eedcdcfd1 src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bfe3086b738064e2957f7598dd3ca24ba1d59eca src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 10c28f5617348745bcd22c00770a9ab08673bdf4 src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 0c37e1fa5acf223eb731457cd12cfe7189f1e39c src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 623c54ee183298ef75060ee43397e7e9a5db3775 src/slave/containerizer/mesos/provisioner/docker/store.cpp 251973c84e5f792dfc89803db5e1796a86e770ba src/tests/containerizer/provisioner_docker_tests.cpp 4f77dcb9df59bbe1cd6561ef0c0102a5c9df027e Diff: https://reviews.apache.org/r/43371/diff/ Testing --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song
Re: Review Request 43371: Cleaned up docker Image::Name proto by ImageReference.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43371/ --- (Updated Feb. 12, 2016, 11:10 a.m.) Review request for mesos and Jie Yu. Repository: mesos Description --- Cleaned up docker Image::Name proto by ImageReference. Diffs (updated) - include/mesos/docker/spec.hpp 6033e824c6f776dc744caf11066b68d3629bb8ca src/slave/containerizer/mesos/provisioner/docker/local_puller.hpp 7f441de097719114f81716caade44388720273f6 src/slave/containerizer/mesos/provisioner/docker/local_puller.cpp abf6ddfcb1b8460fcac5c7c998d8be44ee712266 src/slave/containerizer/mesos/provisioner/docker/message.hpp 43c360862dbb7fa1b2d70825ffbdd5d6be689d93 src/slave/containerizer/mesos/provisioner/docker/message.proto 003c6661f1e2c687dd0ae22161435ef44cc5b5bd src/slave/containerizer/mesos/provisioner/docker/metadata_manager.hpp cb827bfd4d0519d663ebce62a4c4f4646af28a4c src/slave/containerizer/mesos/provisioner/docker/metadata_manager.cpp bf85038f6a7e9940f9c410e7cf4ab50c2432673a src/slave/containerizer/mesos/provisioner/docker/puller.hpp d12b3d0ec9c1c7ce174451e4035e106eedcdcfd1 src/slave/containerizer/mesos/provisioner/docker/registry_client.hpp bfe3086b738064e2957f7598dd3ca24ba1d59eca src/slave/containerizer/mesos/provisioner/docker/registry_client.cpp 10c28f5617348745bcd22c00770a9ab08673bdf4 src/slave/containerizer/mesos/provisioner/docker/registry_puller.hpp 0c37e1fa5acf223eb731457cd12cfe7189f1e39c src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 623c54ee183298ef75060ee43397e7e9a5db3775 src/slave/containerizer/mesos/provisioner/docker/store.cpp 251973c84e5f792dfc89803db5e1796a86e770ba src/tests/containerizer/provisioner_docker_tests.cpp 4f77dcb9df59bbe1cd6561ef0c0102a5c9df027e Diff: https://reviews.apache.org/r/43371/diff/ Testing --- make check (ubuntu14.04 + clang-3.6) Thanks, Gilbert Song
