Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-12 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43514/#review128370 --- Ship it! I'll reword the comment and the description and commit

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43514/ --- (Updated April 8, 2016, 6:32 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43514/ --- (Updated April 8, 2016, 3:48 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43514/ --- (Updated April 8, 2016, 3:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang
> On April 8, 2016, 2:16 p.m., Alexander Rukletsov wrote: > > src/tests/master_tests.cpp, line 68 > > > > > > After the second thought, a better approach would be to create an > > instance of master flags and extract

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43514/#review127787 --- src/tests/master_tests.cpp (line 68)

Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43514/#review127786 --- Fix it, then Ship it! Mind adding the description and do tests