Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-12 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43514/#review128370
---


Ship it!




I'll reword the comment and the description and commit it shortly.

Note that we use past tense in the summary and present in description.

- Alexander Rukletsov


On April 8, 2016, 6:32 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43514/
> ---
> 
> (Updated April 8, 2016, 6:32 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4164
> https://issues.apache.org/jira/browse/MESOS-4164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterTest.RecoverResources by advance allocation interval.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 
> 
> Diff: https://reviews.apache.org/r/43514/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> ```
> sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoverResources" 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43514/
---

(Updated April 8, 2016, 6:32 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4164
https://issues.apache.org/jira/browse/MESOS-4164


Repository: mesos


Description (updated)
---

Speed up MasterTest.RecoverResources by advance allocation interval.


Diffs
-

  src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 

Diff: https://reviews.apache.org/r/43514/diff/


Testing
---

Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoverResources" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang



Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43514/
---

(Updated April 8, 2016, 3:48 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Address @alex's comments.


Bugs: MESOS-4164
https://issues.apache.org/jira/browse/MESOS-4164


Repository: mesos


Description (updated)
---

Speed up MasterTest.RecoverResources.


Diffs (updated)
-

  src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 

Diff: https://reviews.apache.org/r/43514/diff/


Testing
---

Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoverResources" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang



Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43514/
---

(Updated April 8, 2016, 3:43 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Bugs: MESOS-4164
https://issues.apache.org/jira/browse/MESOS-4164


Repository: mesos


Description (updated)
---

Speed up MasterTest.RecoverResources by advance allocation interval.


Diffs (updated)
-

  src/tests/master_tests.cpp 8f93fbaf2bfd66bbc144a85c0097f45c55ff3491 

Diff: https://reviews.apache.org/r/43514/diff/


Testing (updated)
---

Repeat test in CentOS 7.1
```
sudo ./bin/mesos-tests.sh --gtest_filter="MasterTest.RecoverResources" 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang



Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread haosdent huang


> On April 8, 2016, 2:16 p.m., Alexander Rukletsov wrote:
> > src/tests/master_tests.cpp, line 68
> > 
> >
> > After the second thought, a better approach would be to create an 
> > instance of master flags and extract the allocator interval from there.

Got it, let me updated.


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43514/#review127787
---


On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43514/
> ---
> 
> (Updated Feb. 12, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4164
> https://issues.apache.org/jira/browse/MESOS-4164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterTest.RecoverResources.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
> 
> Diff: https://reviews.apache.org/r/43514/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43514/#review127787
---




src/tests/master_tests.cpp (line 68)


After the second thought, a better approach would be to create an instance 
of master flags and extract the allocator interval from there.


- Alexander Rukletsov


On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43514/
> ---
> 
> (Updated Feb. 12, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4164
> https://issues.apache.org/jira/browse/MESOS-4164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterTest.RecoverResources.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
> 
> Diff: https://reviews.apache.org/r/43514/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 43514: Speed up MasterTest.RecoverResources.

2016-04-08 Thread Alexander Rukletsov

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43514/#review127786
---


Fix it, then Ship it!




Mind adding the description and do tests in repetition?


src/tests/master_tests.cpp (line 745)


I believe you do settle in order to make sure the container is destroyed. 
Mind writing a comment?

Also, I think you can resume the clock right after advancing.


- Alexander Rukletsov


On Feb. 12, 2016, 6:36 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43514/
> ---
> 
> (Updated Feb. 12, 2016, 6:36 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4164
> https://issues.apache.org/jira/browse/MESOS-4164
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up MasterTest.RecoverResources.
> 
> 
> Diffs
> -
> 
>   src/tests/master_tests.cpp 393a6f5fe3744d6ba743f362b7e309d1ee75a303 
> 
> Diff: https://reviews.apache.org/r/43514/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>