Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

2016-04-09 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review127972
---



Patch looks great!

Reviews applied: [43520]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 9, 2016, 6:18 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> ---
> 
> (Updated April 9, 2016, 6:18 a.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GarbageCollectorIntegrationTest.Restart by advance allocation
> interval.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 
> 
> Diff: https://reviews.apache.org/r/43520/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> 
> ```
> $ sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>



Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

2016-04-09 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
---

(Updated April 9, 2016, 6:18 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update description.


Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172


Repository: mesos


Description (updated)
---

Speed up GarbageCollectorIntegrationTest.Restart by advance allocation
interval.


Diffs
-

  src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 

Diff: https://reviews.apache.org/r/43520/diff/


Testing
---

Repeat test in CentOS 7.1

```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang



Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

2016-04-09 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
---

(Updated April 9, 2016, 6:09 a.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Update according to @alexr's comments.


Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172


Repository: mesos


Description
---

Speed up GarbageCollectorIntegrationTest.Restart.


Diffs (updated)
-

  src/tests/cluster.cpp 7e488d28b7a0d3bef9cd76bf7df2de4822256ef6 

Diff: https://reviews.apache.org/r/43520/diff/


Testing (updated)
---

Repeat test in CentOS 7.1

```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang



Re: Review Request 43520: Speed up GarbageCollectorIntegrationTest.Restart.

2016-02-12 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review118991
---



Patch looks great!

Reviews applied: [43520]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 12, 2016, 6:46 a.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> ---
> 
> (Updated Feb. 12, 2016, 6:46 a.m.)
> 
> 
> Review request for mesos and Ben Mahler.
> 
> 
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GarbageCollectorIntegrationTest.Restart.
> 
> 
> Diffs
> -
> 
>   src/tests/cluster.cpp 084fb1ce37a315c561c4587c4761c870f54c8625 
> 
> Diff: https://reviews.apache.org/r/43520/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> haosdent huang
> 
>