Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

2016-07-12 Thread Alexander Rukletsov 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review141894
---


Fix it, then Ship it!




I'll commit this now.


src/tests/gc_tests.cpp (lines 268 - 269)


Blank line.


- Alexander Rukletsov


On April 16, 2016, 3:37 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> ---
> 
> (Updated April 16, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GarbageCollectorIntegrationTest.Restart by reduce
> `executor_shutdown_grace_period`.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 
> 
> Diff: https://reviews.apache.org/r/43520/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> 
> ```
> $ sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

2016-06-06 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review136241
---


Ship it!




Ship It!

- Neil Conway


On April 16, 2016, 3:37 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> ---
> 
> (Updated April 16, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Benjamin Mahler.
> 
> 
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GarbageCollectorIntegrationTest.Restart by reduce
> `executor_shutdown_grace_period`.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 
> 
> Diff: https://reviews.apache.org/r/43520/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> 
> ```
> $ sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

2016-04-16 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/#review129252
---



Patch looks great!

Reviews applied: [43520]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 16, 2016, 3:37 p.m., haosdent huang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43520/
> ---
> 
> (Updated April 16, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Alexander Rukletsov and Ben Mahler.
> 
> 
> Bugs: MESOS-4172
> https://issues.apache.org/jira/browse/MESOS-4172
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Speed up GarbageCollectorIntegrationTest.Restart by reduce
> `executor_shutdown_grace_period`.
> 
> 
> Diffs
> -
> 
>   src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 
> 
> Diff: https://reviews.apache.org/r/43520/diff/
> 
> 
> Testing
> ---
> 
> Repeat test in CentOS 7.1
> 
> ```
> $ sudo GLOG_v=1 ./bin/mesos-tests.sh 
> --gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
> --gtest_repeat=200 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> haosdent huang
> 
>

Re: Review Request 43520: Speeded up GarbageCollectorIntegrationTest.Restart.

2016-04-16 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43520/
---

(Updated April 16, 2016, 3:37 p.m.)


Review request for mesos, Alexander Rukletsov and Ben Mahler.


Changes
---

Speed up GarbageCollectorIntegrationTest.Restart by reduce
`executor_shutdown_grace_period`.


Summary (updated)
-

Speeded up GarbageCollectorIntegrationTest.Restart.


Bugs: MESOS-4172
https://issues.apache.org/jira/browse/MESOS-4172


Repository: mesos


Description (updated)
---

Speed up GarbageCollectorIntegrationTest.Restart by reduce
`executor_shutdown_grace_period`.


Diffs (updated)
-

  src/tests/gc_tests.cpp 4cb7c2f612984f7f5a9378a7f972f2438bbf28c5 

Diff: https://reviews.apache.org/r/43520/diff/


Testing
---

Repeat test in CentOS 7.1

```
$ sudo GLOG_v=1 ./bin/mesos-tests.sh 
--gtest_filter="GarbageCollectorIntegrationTest.Restart" --verbose 
--gtest_repeat=200 --gtest_break_on_failure
```


Thanks,

haosdent huang