Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review167346 --- Closing this review due to inactivity. Please see our

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review143133 --- Patch looks great! Reviews applied: [50280, 50285, 49223, 43561]

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated July 21, 2016, 11:43 p.m.) Review request for mesos, Alexander

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 2:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n",

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review143031 --- Can you rebase this on top of

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, lines 612-627 > > > > > > Should we add a benchmark here to understand the effect of now having 3 > > levels of `tokenize`? >

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/tests/values_tests.cpp, lines 39-72 > > > > > > It would be great to split apart this test into the respective value > > types, e.g. > > > > ```

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review137121 --- Patch looks great! Reviews applied: [43561] Passed command:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/tests/values_tests.cpp, line 210 > > > > > > If I understand correctly, the following are currently accepted way to > > specify 1-4: > > > >

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated June 11, 2016, 10:29 p.m.) Review request for mesos, Alexander

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > src/common/values.cpp, lines 654-657 > > > > > > Can you pull this cleanup into a separate patch? Note that you don't > > need the variable: > > > >

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On June 8, 2016, 5:32 a.m., Benjamin Mahler wrote: > > Hi Klaus sorry for the delay. > > > > This piece of code is very old in Mesos and has some significant technical > > debt. We should have used a parsing library here but at the time we didn't > > have because we hadn't moved to C++11

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review136543 --- Hi Klaus sorry for the delay. This piece of code is very old in

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n",

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n",

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, lines 612-627 > > > > > > Should we add a benchmark here to understand the effect of now having 3 > > levels of `tokenize`? >

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 612 > > > > > > Not yours: We shouldn't capture temporaries by reference. > > Either: > > 1) capture by value:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 612 > > > > > > Not yours: We shouldn't capture temporaries by reference. > > Either: > > 1) capture by value:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

> On March 21, 2016, 10:02 p.m., Joris Van Remoortere wrote: > > src/common/values.cpp, line 613 > > > > > > @benm I wish we had support for iterating over these splicers eg: > > `foreachtoken(temp, ",\n",

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated March 22, 2016, 9:22 p.m.) Review request for mesos, Alexander

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated March 22, 2016, 8:25 p.m.) Review request for mesos, Alexander

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review124545 --- src/common/values.cpp (line 612)

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review121229 --- Patch looks great! Reviews applied: [43561] Passed command:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated Feb. 29, 2016, 5:57 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/#review119171 --- Patch looks great! Reviews applied: [43561] Passed command:

Re: Review Request 43561: Improve Ranges parsing to handle single values.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43561/ --- (Updated Feb. 14, 2016, 2:38 p.m.) Review request for mesos and Ben Mahler.