Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review120238 --- Fix it, then Ship it! src/tests/reservation_tests.cpp (line

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Guangya Liu
> On 二月 18, 2016, 6:57 a.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 692-711 > > > > > > Can you please add some test cases to cover those scenarios? > > > > 1) authentication is enabled and

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Michael Park
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review120233 --- Ship it! Ship It! - Michael Park On Feb. 23, 2016, 12:16

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/ --- (Updated Feb. 23, 2016, 12:16 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review120207 --- src/tests/reservation_endpoints_tests.cpp (line 1269)

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Neil Conway
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review120209 --- Fix it, then Ship it! src/tests/reservation_tests.cpp (line

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-22 Thread Greg Mann
> On Feb. 18, 2016, 6:57 a.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 692-711 > > > > > > Can you please add some test cases to cover those scenarios? > > > > 1) authentication is enabled

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/ --- (Updated Feb. 20, 2016, 1:53 a.m.) Review request for mesos, Michael Park and

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-17 Thread Guangya Liu
> On 二月 18, 2016, 6:57 a.m., Guangya Liu wrote: > > src/master/validation.cpp, lines 692-711 > > > > > > Can you please add some test cases to cover those scenarios? > > > > 1) authentication is enabled and

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-17 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/#review119589 --- src/master/validation.cpp (lines 675 - 694)

Re: Review Request 43639: Allowed dynamic reservation without a principal.

2016-02-17 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43639/ --- (Updated Feb. 17, 2016, 8:45 p.m.) Review request for mesos, Michael Park and