Re: Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.

2016-02-22 Thread Vinod Kone 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43657/#review120217
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 18, 2016, 4:54 a.m., Anand Mazumdar wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43657/
> ---
> 
> (Updated Feb. 18, 2016, 4:54 a.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-3570
> https://issues.apache.org/jira/browse/MESOS-3570
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Moved the detector pointer to `process::Owned` so that it is cleaned up later.
> 
> 
> Diffs
> -
> 
>   src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 
> 
> Diff: https://reviews.apache.org/r/43657/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Anand Mazumdar
> 
>

Re: Review Request 43657: Fixed MasterDetector pointer leak in scheduler library.

2016-02-17 Thread Anand Mazumdar 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43657/
---

(Updated Feb. 18, 2016, 4:54 a.m.)


Review request for mesos and Vinod Kone.


Changes
---

Moved from `process::Owned` to `std::shared_ptr` similar to 
`MesosSchedulerDriver`. This also helps when passing a `MasterDetector` object 
while testing.


Bugs: MESOS-3570
https://issues.apache.org/jira/browse/MESOS-3570


Repository: mesos


Description
---

Moved the detector pointer to `process::Owned` so that it is cleaned up later.


Diffs (updated)
-

  src/scheduler/scheduler.cpp 99a7d0dfff7b0c61decc9ff6d9e6d46ef13a7e75 

Diff: https://reviews.apache.org/r/43657/diff/


Testing
---

make check


Thanks,

Anand Mazumdar