Re: Review Request 43673: Searialized invocation of `await` in the status method.

2016-02-17 Thread Avinash sridharan


> On Feb. 17, 2016, 9:18 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/containerizer.cpp, line 1330
> > 
> >
> > Why this change?
> 
> Avinash sridharan wrote:
> During debugging was finding it hard to ascertain if the 
> `MesosContainerizer` was successfully able to complete the status request, 
> and hence thought will bump up the log to make sure we are able to track 
> every stage of the pipe line.

Removed the log level. Will create a separate patch if required.


- Avinash


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43673/#review119525
---


On Feb. 17, 2016, 10:20 p.m., Avinash sridharan wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43673/
> ---
> 
> (Updated Feb. 17, 2016, 10:20 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4671
> https://issues.apache.org/jira/browse/MESOS-4671
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Searialized invocation of `await` in the status method.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/containerizer.cpp 
> 3de214d6c71773f5deb5db9fe3f527dd5064737f 
> 
> Diff: https://reviews.apache.org/r/43673/diff/
> 
> 
> Testing
> ---
> 
> make, make check and `sudo make check`
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>



Re: Review Request 43673: Searialized invocation of `await` in the status method.

2016-02-17 Thread Avinash sridharan

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43673/
---

(Updated Feb. 17, 2016, 10:20 p.m.)


Review request for mesos and Jie Yu.


Changes
---

Fixed review comments.


Bugs: MESOS-4671
https://issues.apache.org/jira/browse/MESOS-4671


Repository: mesos


Description
---

Searialized invocation of `await` in the status method.


Diffs (updated)
-

  src/slave/containerizer/mesos/containerizer.cpp 
3de214d6c71773f5deb5db9fe3f527dd5064737f 

Diff: https://reviews.apache.org/r/43673/diff/


Testing (updated)
---

make, make check and `sudo make check`


Thanks,

Avinash sridharan