Re: Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

2016-02-18 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43730/#review119731
---



Patch looks great!

Reviews applied: [38117, 43730]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 18, 2016, 7:15 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43730/
> ---
> 
> (Updated Feb. 18, 2016, 7:15 p.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As Neil Conway noticed, we should add these SNMP statistics to v1 mesos.proto 
> too.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43730/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Cong Wang
> 
>

Re: Review Request 43730: Added SNMP statistics to v1 mesos.proto too.

2016-02-18 Thread Ian Downes 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43730/#review119687
---


Ship it!




Ship It!

- Ian Downes


On Feb. 18, 2016, 11:15 a.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43730/
> ---
> 
> (Updated Feb. 18, 2016, 11:15 a.m.)
> 
> 
> Review request for mesos, Ian Downes, Jie Yu, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> As Neil Conway noticed, we should add these SNMP statistics to v1 mesos.proto 
> too.
> 
> 
> Diffs
> -
> 
>   include/mesos/v1/mesos.proto d909e60ddfd8e3ba2075f82c372edde04cd99d54 
> 
> Diff: https://reviews.apache.org/r/43730/diff/
> 
> 
> Testing
> ---
> 
> make
> 
> 
> Thanks,
> 
> Cong Wang
> 
>