Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-26 Thread Ben Mahler
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43760/#review120928 --- src/exec/exec.cpp (line 693)

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Guangya Liu
> On 二月 19, 2016, 1:38 p.m., Guangya Liu wrote: > > src/exec/exec.cpp, lines 698-699 > > > > > > Since there is already a default value for `shutdownGracePeriod` here, > > what about just log warning message here

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Alexander Rukletsov
> On Feb. 19, 2016, 1:38 p.m., Guangya Liu wrote: > > src/exec/exec.cpp, lines 698-699 > > > > > > Since there is already a default value for `shutdownGracePeriod` here, > > what about just log warning message here

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Guangya Liu
> On 二月 19, 2016, 1:38 p.m., Guangya Liu wrote: > > src/exec/exec.cpp, lines 698-699 > > > > > > Since there is already a default value for `shutdownGracePeriod` here, > > what about just log warning message here

Re: Review Request 43760: Propagated executor shutdown grace period to executors.

2016-02-19 Thread Guangya Liu
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43760/#review119875 --- src/exec/exec.cpp (lines 697 - 698)