Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43769/#review119953
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 19, 2016, 6:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43769/
> ---
> 
> (Updated Feb. 19, 2016, 6:54 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about resending of KillTaskMessages between Master and Agent.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
> 
> Diff: https://reviews.apache.org/r/43769/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43769/#review119924
---


Ship it!




Ship It!

- Alexander Rojas


On Feb. 19, 2016, 7:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43769/
> ---
> 
> (Updated Feb. 19, 2016, 7:54 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about resending of KillTaskMessages between Master and Agent.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
> 
> Diff: https://reviews.apache.org/r/43769/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Joerg Schad

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43769/
---

(Updated Feb. 19, 2016, 6:54 p.m.)


Review request for mesos, Joris Van Remoortere and Vinod Kone.


Changes
---

Made formatting consisting according to Alexanders review.


Repository: mesos


Description
---

Added note about resending of KillTaskMessages between Master and Agent.


Diffs (updated)
-

  src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 

Diff: https://reviews.apache.org/r/43769/diff/


Testing
---


Thanks,

Joerg Schad



Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43769/#review119920
---




src/master/master.cpp (lines 3856 - 3858)


Could you keep a column limit that matches the one of the previous two 
lines (or change those two lines so that they are 80 columns width).


- Alexander Rojas


On Feb. 19, 2016, 6:15 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43769/
> ---
> 
> (Updated Feb. 19, 2016, 6:15 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about resending of KillTaskMessages between Master and Agent.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
> 
> Diff: https://reviews.apache.org/r/43769/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 43769: Added note about resending of KillTaskMessages between Master and Agent.

2016-02-19 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43769/#review119915
---



Patch looks great!

Reviews applied: [43769]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 19, 2016, 5:15 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43769/
> ---
> 
> (Updated Feb. 19, 2016, 5:15 p.m.)
> 
> 
> Review request for mesos, Joris Van Remoortere and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added note about resending of KillTaskMessages between Master and Agent.
> 
> 
> Diffs
> -
> 
>   src/master/master.cpp e1ca81dab85a7ab1391eca0d6bd995548bf79c22 
> 
> Diff: https://reviews.apache.org/r/43769/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>