Re: Review Request 43790: Fixed container ids used in docker tests.

2016-02-19 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43790/
---

(Updated Feb. 19, 2016, 11:46 p.m.)


Review request for mesos and Jie Yu.


Repository: mesos


Description (updated)
---

Fixed container ids used in docker tests.

Currently in Docker Containerizer recover we attempt to unmount all volumes 
that belong to the orphaned/recovered container, which we assume all volumes 
containing the container id belongs to us.

However in the tests since we use a very simple container ID name (e.g: c2, 
c1), we easily match other unintended volumes and try to unmount them. This 
causes tests failures in some situations. 

By picking a truly random ContainerID will avoid this.


Diffs
-

  src/tests/containerizer/docker_containerizer_tests.cpp 
8541a9a3d2f40cd6e78ff8fba474da214017937a 

Diff: https://reviews.apache.org/r/43790/diff/


Testing
---

make check


Thanks,

Timothy Chen



Re: Review Request 43790: Fixed container ids used in docker tests.

2016-02-19 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43790/#review119992
---


Ship it!




Ship It!

- Jie Yu


On Feb. 19, 2016, 11:34 p.m., Timothy Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43790/
> ---
> 
> (Updated Feb. 19, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Fixed container ids used in docker tests.
> 
> Currently in Docker Containerizer recover we attempt to unmount all volumes 
> that belong to the orphaned/recovered container, which we assume all volumes 
> containing the container id belongs to us.
> 
> However in the tests since we use a very simple container ID name (e.g: c2, 
> c1), we easily match other untended volumes and try to unmount them. This 
> causes tests failures in some situations. 
> 
> By picking a truly random ContainerID will avoid this.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/docker_containerizer_tests.cpp 
> 8541a9a3d2f40cd6e78ff8fba474da214017937a 
> 
> Diff: https://reviews.apache.org/r/43790/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Timothy Chen
> 
>