Re: Review Request 43806: Add comments for rebalance.

2016-03-03 Thread Yongqiao Wang
> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069 > > > > > > For posterity, we backtick types and variables names. > > Yongqiao Wang wrote:

Re: Review Request 43806: Add comments for rebalance.

2016-03-03 Thread Alexander Rukletsov
> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069 > > > > > > For posterity, we backtick types and variables names. > > Yongqiao Wang wrote:

Re: Review Request 43806: Add comments for rebalance.

2016-03-03 Thread Yongqiao Wang
> On March 2, 2016, 2:07 p.m., Alexander Rukletsov wrote: > > src/master/allocator/mesos/hierarchical.cpp, lines 1066-1069 > > > > > > For posterity, we backtick types and variables names. Do you mean we should

Re: Review Request 43806: Add comments for rebalance.

2016-03-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review121641 --- src/master/allocator/mesos/hierarchical.cpp (lines 1066 - 1069)

Re: Review Request 43806: Add comments for rebalance.

2016-02-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review121087 --- Ship it! Ship It! - Adam B On Feb. 27, 2016, 4:26 a.m.,

Re: Review Request 43806: Add comments for rebalance.

2016-02-27 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/ --- (Updated Feb. 27, 2016, 12:26 p.m.) Review request for mesos, Adam B and

Re: Review Request 43806: Add comments for rebalance.

2016-02-27 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review121079 --- I took a stab at rewording your comment. I particularly didn't

Re: Review Request 43806: Add comments for rebalance.

2016-02-20 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43806/#review120057 --- Patch looks great! Reviews applied: [43806] Passed command: