Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/#review121113 --- Ship it! Ship It! - Michael Park On Feb. 28, 2016, 12:15 a.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43816/ > --- > > (Updated Feb. 28, 2016, 12:15 a.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4731 > https://issues.apache.org/jira/browse/MESOS-4731 > > > Repository: mesos > > > Description > --- > > Updated `/frameworks` master endpoint to use jsonify. > > > Diffs > - > > src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 > > Diff: https://reviews.apache.org/r/43816/diff/ > > > Testing > --- > > 1. make check > 2. Verified that after introducing a bug into the jsonify version of > `frameworks()`, `make check` fails (i.e., the test suite covers the > `/frameworks` endpoint). > 3. Compared output of `/frameworks` with old and new implementation on a test > Mesos installation to try to gauge correctness visually. > > > Thanks, > > Neil Conway > >
Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/ --- (Updated Feb. 28, 2016, 12:15 a.m.) Review request for mesos and Michael Park. Changes --- Rebase. Bugs: MESOS-4731 https://issues.apache.org/jira/browse/MESOS-4731 Repository: mesos Description --- Updated `/frameworks` master endpoint to use jsonify. Diffs (updated) - src/master/http.cpp f3ce1aa22f5f753fcb254e9ecaa8ba571e3d2829 Diff: https://reviews.apache.org/r/43816/diff/ Testing --- 1. make check 2. Verified that after introducing a bug into the jsonify version of `frameworks()`, `make check` fails (i.e., the test suite covers the `/frameworks` endpoint). 3. Compared output of `/frameworks` with old and new implementation on a test Mesos installation to try to gauge correctness visually. Thanks, Neil Conway
Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/ --- (Updated Feb. 23, 2016, 10:29 p.m.) Review request for mesos and Michael Park. Changes --- Rebase. Bugs: MESOS-4731 https://issues.apache.org/jira/browse/MESOS-4731 Repository: mesos Description --- Updated `/frameworks` master endpoint to use jsonify. Diffs (updated) - src/master/http.cpp 939fab21a2240de7214ef809a194ffb3837a9f1b Diff: https://reviews.apache.org/r/43816/diff/ Testing --- 1. make check 2. Verified that after introducing a bug into the jsonify version of `frameworks()`, `make check` fails (i.e., the test suite covers the `/frameworks` endpoint). 3. Compared output of `/frameworks` with old and new implementation on a test Mesos installation to try to gauge correctness visually. Thanks, Neil Conway
Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/#review120272 --- Ship it! Ship It! - Klaus Ma On Feb. 22, 2016, 3:11 p.m., Neil Conway wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43816/ > --- > > (Updated Feb. 22, 2016, 3:11 p.m.) > > > Review request for mesos and Michael Park. > > > Bugs: MESOS-4731 > https://issues.apache.org/jira/browse/MESOS-4731 > > > Repository: mesos > > > Description > --- > > Updated `/frameworks` master endpoint to use jsonify. > > > Diffs > - > > src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 > > Diff: https://reviews.apache.org/r/43816/diff/ > > > Testing > --- > > 1. make check > 2. Verified that after introducing a bug into the jsonify version of > `frameworks()`, `make check` fails (i.e., the test suite covers the > `/frameworks` endpoint). > 3. Compared output of `/frameworks` with old and new implementation on a test > Mesos installation to try to gauge correctness visually. > > > Thanks, > > Neil Conway > >
Re: Review Request 43816: Updated `/frameworks` master endpoint to use jsonify.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43816/ --- (Updated Feb. 22, 2016, 7:11 a.m.) Review request for mesos and Michael Park. Summary (updated) - Updated `/frameworks` master endpoint to use jsonify. Bugs: MESOS-4731 https://issues.apache.org/jira/browse/MESOS-4731 Repository: mesos Description (updated) --- Updated `/frameworks` master endpoint to use jsonify. Diffs (updated) - src/master/http.cpp ae6bc7852202480e58f579a5b48ab5b5e5ff9317 Diff: https://reviews.apache.org/r/43816/diff/ Testing --- 1. make check 2. Verified that after introducing a bug into the jsonify version of `frameworks()`, `make check` fails (i.e., the test suite covers the `/frameworks` endpoint). 3. Compared output of `/frameworks` with old and new implementation on a test Mesos installation to try to gauge correctness visually. Thanks, Neil Conway
