Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-28 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/#review121156 --- Ship it! Ship It! - Vinod Kone On Feb. 27, 2016, 4:48 a.m.,

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-26 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/ --- (Updated Feb. 27, 2016, 4:48 a.m.) Review request for mesos and Vinod Kone. C

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-26 Thread Anand Mazumdar
> On Feb. 27, 2016, 2:43 a.m., Vinod Kone wrote: > > src/scheduler/scheduler.cpp, lines 637-638 > > > > > > Yikes. Why are you doing it like this, instead of passing detector as > > an optional argument to the Mesos

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-26 Thread Vinod Kone
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/#review121054 --- include/mesos/v1/scheduler.hpp (line 77)

Re: Review Request 43846: Added support for specifying detector to the callback interface.

2016-02-22 Thread Anand Mazumdar
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43846/ --- (Updated Feb. 22, 2016, 8:24 p.m.) Review request for mesos and Vinod Kone. C