----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43850/#review120196 -----------------------------------------------------------
src/tests/containerizer/memory_pressure_tests.cpp (line 231) <https://reviews.apache.org/r/43850/#comment181621> Maybe rename this to runningStatus? src/tests/containerizer/memory_pressure_tests.cpp (line 292) <https://reviews.apache.org/r/43850/#comment181623> Do we still need this at this point? - Joerg Schad On Feb. 22, 2016, 9:12 p.m., Alexander Rojas wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/43850/ > ----------------------------------------------------------- > > (Updated Feb. 22, 2016, 9:12 p.m.) > > > Review request for mesos, Bernd Mathiske and Joseph Wu. > > > Repository: mesos > > > Description > ------- > > Sometimes MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery will fail because > the tracker of the cgroups pressure counter is not finished by the time the > expectations are set. > > This patch ensures that the killed status has arrived before checking for the > pressure values. > > > Diffs > ----- > > src/tests/containerizer/memory_pressure_tests.cpp > 4a03af2c9c0643d964b1d76e2096341b59bf5dce > > Diff: https://reviews.apache.org/r/43850/diff/ > > > Testing > ------- > > On a CentOS 6.7 virtual box machine: > > ```bash > MESOS_VERBOSE=1 sudo .libs/mesos-tests > --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" > --gtest_repeat=300 --gtest_break_on_failure > ``` > > > Thanks, > > Alexander Rojas > >
