Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

2016-02-24 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/#review120594
---


Ship it!




Ship It!

- Joseph Wu


On Feb. 24, 2016, 1:44 p.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43850/
> ---
> 
> (Updated Feb. 24, 2016, 1:44 p.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joseph Wu.
> 
> 
> Bugs: MESOS-4047
> https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sometimes _MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery_ will fail 
> because
> the tracker of the cgroups pressure counter is not finished by the time the
> expectations are set.
> 
> This patch ensures that different test milestones are reached; e.g. slave
> is registered, `KILLED_TASK` reached the scheduler, etc; before continuing
> with the test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
> 
> Diff: https://reviews.apache.org/r/43850/diff/
> 
> 
> Testing
> ---
> 
> On a CentOS 6.7 virtual box machine:
> 
> ```bash
> MESOS_VERBOSE=1 sudo .libs/mesos-tests 
> --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
> --gtest_repeat=1000 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>



Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

2016-02-24 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/
---

(Updated Feb. 24, 2016, 10:44 p.m.)


Review request for mesos, Bernd Mathiske and Joseph Wu.


Changes
---

Remove typo.


Summary (updated)
-

Added waits at different points in the test to ensure milestones.


Bugs: MESOS-4047
https://issues.apache.org/jira/browse/MESOS-4047


Repository: mesos


Description (updated)
---

Sometimes _MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery_ will fail because
the tracker of the cgroups pressure counter is not finished by the time the
expectations are set.

This patch ensures that different test milestones are reached; e.g. slave
is registered, `KILLED_TASK` reached the scheduler, etc; before continuing
with the test.


Diffs
-

  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 

Diff: https://reviews.apache.org/r/43850/diff/


Testing
---

On a CentOS 6.7 virtual box machine:

```bash
MESOS_VERBOSE=1 sudo .libs/mesos-tests 
--gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
--gtest_repeat=1000 --gtest_break_on_failure
```


Thanks,

Alexander Rojas



Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

2016-02-24 Thread Joseph Wu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/#review120526
---




src/tests/containerizer/memory_pressure_tests.cpp (lines 158 - 161)


Presumably, this section has the same race.



src/tests/containerizer/memory_pressure_tests.cpp (line 253)


Missed s/status/running/ here.


- Joseph Wu


On Feb. 24, 2016, 1:10 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43850/
> ---
> 
> (Updated Feb. 24, 2016, 1:10 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joseph Wu.
> 
> 
> Bugs: MESOS-4047
> https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sometimes MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery will fail because
> the tracker of the cgroups pressure counter is not finished by the time the
> expectations are set.
> 
> This patch ensures that different test milestones are reached; e.g. slave
> is registered, KILLED_TASK reached the scheduler, etc; before continuing
> with the test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
> 
> Diff: https://reviews.apache.org/r/43850/diff/
> 
> 
> Testing
> ---
> 
> On a CentOS 6.7 virtual box machine:
> 
> ```bash
> MESOS_VERBOSE=1 sudo .libs/mesos-tests 
> --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
> --gtest_repeat=1000 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>



Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

2016-02-24 Thread Bernd Mathiske

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/#review120475
---


Ship it!





src/tests/containerizer/memory_pressure_tests.cpp (line 242)


Nice pattern. We try not to capture by reference, but here this is put to 
use to great effect.


- Bernd Mathiske


On Feb. 24, 2016, 1:10 a.m., Alexander Rojas wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43850/
> ---
> 
> (Updated Feb. 24, 2016, 1:10 a.m.)
> 
> 
> Review request for mesos, Bernd Mathiske and Joseph Wu.
> 
> 
> Bugs: MESOS-4047
> https://issues.apache.org/jira/browse/MESOS-4047
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Sometimes MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery will fail because
> the tracker of the cgroups pressure counter is not finished by the time the
> expectations are set.
> 
> This patch ensures that different test milestones are reached; e.g. slave
> is registered, KILLED_TASK reached the scheduler, etc; before continuing
> with the test.
> 
> 
> Diffs
> -
> 
>   src/tests/containerizer/memory_pressure_tests.cpp 
> 4a03af2c9c0643d964b1d76e2096341b59bf5dce 
> 
> Diff: https://reviews.apache.org/r/43850/diff/
> 
> 
> Testing
> ---
> 
> On a CentOS 6.7 virtual box machine:
> 
> ```bash
> MESOS_VERBOSE=1 sudo .libs/mesos-tests 
> --gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
> --gtest_repeat=1000 --gtest_break_on_failure
> ```
> 
> 
> Thanks,
> 
> Alexander Rojas
> 
>



Re: Review Request 43850: Added waits at different points in the test to ensure milestones.

2016-02-24 Thread Alexander Rojas

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43850/
---

(Updated Feb. 24, 2016, 1:10 a.m.)


Review request for mesos, Bernd Mathiske and Joseph Wu.


Changes
---

fixed typo


Summary (updated)
-

Added waits at different points in the test to ensure milestones.


Bugs: MESOS-4047
https://issues.apache.org/jira/browse/MESOS-4047


Repository: mesos


Description
---

Sometimes MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery will fail because
the tracker of the cgroups pressure counter is not finished by the time the
expectations are set.

This patch ensures that different test milestones are reached; e.g. slave
is registered, KILLED_TASK reached the scheduler, etc; before continuing
with the test.


Diffs
-

  src/tests/containerizer/memory_pressure_tests.cpp 
4a03af2c9c0643d964b1d76e2096341b59bf5dce 

Diff: https://reviews.apache.org/r/43850/diff/


Testing
---

On a CentOS 6.7 virtual box machine:

```bash
MESOS_VERBOSE=1 sudo .libs/mesos-tests 
--gtest_filter="MemoryPressureMesosTest.CGROUPS_ROOT_SlaveRecovery" 
--gtest_repeat=1000 --gtest_break_on_failure
```


Thanks,

Alexander Rojas