Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Joris Van Remoortere]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121598
---


Ship it!




Ship It!

- Joris Van Remoortere


On March 2, 2016, 6:15 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated March 2, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.patch  
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/slave/cmake/SlaveConfigure.cmake 
> 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121596
---


Ship it!




I'm voting ship it, but I do want to call out that I know almost nothing about 
the autotools build, so I'm not exactly qualified to vote on that.

- Alex Clemmer


On March 2, 2016, 6:15 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated March 2, 2016, 6:15 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.patch  
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
>   LICENSE c3aaa437af10533132698df3348114195d338965 
>   src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
>   src/python/native/ext_modules.py.in 
> 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
>   src/slave/cmake/SlaveConfigure.cmake 
> 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
---

(Updated March 2, 2016, 6:15 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, Joseph Wu, and Till Toenshoff.


Changes
---

More changes to handle rename in automake of leveldb to leveldb-1.4.


Bugs: MESOS-4746
https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description
---

CMake: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
  3rdparty/Makefile.am 3782583b7683d9d3bb61e7e8a1953bc3f61055f0 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
  3rdparty/leveldb.patch  
  3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
  3rdparty/versions.am 3f4513d960901bc0c014cc7ca148bf5bd43f5995 
  LICENSE c3aaa437af10533132698df3348114195d338965 
  src/Makefile.am 5d8fe8bf33acb352589b2b3e0341987f9a41bc17 
  src/python/native/ext_modules.py.in 4682e5eed0f7be23fb48ef628e1bebc7741431d7 
  src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121561
---




3rdparty/CMakeLists.txt (line 30)


Oh wait. Sorry, I marked this as ship it, but you forgot to update the 
Makefile.am (my build just failed as a result).

As soon as you update that and test the build, you should push this up, and 
then I think it's ready to go.


- Alex Clemmer


On March 2, 2016, 12:52 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated March 2, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   src/slave/cmake/SlaveConfigure.cmake 
> 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Alex Clemmer]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review121560
---


Ship it!




- Alex Clemmer


On March 2, 2016, 12:52 a.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated March 2, 2016, 12:52 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMake: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
>   3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
>   3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
>   3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
>   src/slave/cmake/SlaveConfigure.cmake 
> 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMake: Add leveldb library to 3rdparty external builds.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
---

(Updated March 2, 2016, 12:52 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, Joseph Wu, and Till Toenshoff.


Summary (updated)
-

CMake: Add leveldb library to 3rdparty external builds.


Bugs: MESOS-4746
https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description (updated)
---

CMake: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-

  3rdparty/CMakeLists.txt 68020dca6a4ea9790c9a54e5e33aa47674581a58 
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
aaf1651e155b27a4f2cb72b4586d0d3d94a95b11 
  3rdparty/cmake/Versions.cmake 932f2f66b04e5ca3d2ed04da1e7019d2ff7488e4 
  3rdparty/leveldb-1.4.tar.gz PRE-CREATION 
  3rdparty/leveldb.tar.gz b6ea2c7df8f0eef687f9ad90af70f35f81743cbc 
  src/slave/cmake/SlaveConfigure.cmake 5697a0bfa52e8ea15563bc0668ec63aadbb01ed3 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

[Alex Clemmer]

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/cmake/macros/External.cmake, line 38
> > 
> >
> > And why we need change `EXTERNAL` macro here? I prososal add a version 
> > to our leveldb.tar.gz
> 
> Diana Arroyo wrote:
> I expect we will need to get an agreement with the folks who maintain the 
> make build.  Who is the person that need to be pulled into this discussion?
> 
> haosdent huang wrote:
> I think maybe @tillt
> 
> Diana Arroyo wrote:
> I added @tillt to the reviewers.  Will await response.

I will maintain the CMake build.

I think that haosdent's idea here is actually pretty good. Attaching a version 
# to `leveldb.tar.gz` will cause us to shrink this commit to a handful of lines 
in the `Makefile.am`. Specifically, you'll need ot (1) rename `leveldb.tar.gz` 
and you'll need to change this line here: 
https://github.com/apache/mesos/blob/master/3rdparty/Makefile.am#L36


- Alex


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120353
---


On Feb. 25, 2016, 7:42 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 25, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

[Diana Arroyo]

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/cmake/macros/External.cmake, line 38
> > 
> >
> > And why we need change `EXTERNAL` macro here? I prososal add a version 
> > to our leveldb.tar.gz
> 
> Diana Arroyo wrote:
> I expect we will need to get an agreement with the folks who maintain the 
> make build.  Who is the person that need to be pulled into this discussion?
> 
> haosdent huang wrote:
> I think maybe @tillt

I added @tillt to the reviewers.  Will await response.


- Diana


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120353
---


On Feb. 25, 2016, 7:42 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 25, 2016, 7:42 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, Joseph Wu, and Till Toenshoff.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds.
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
---

(Updated Feb. 25, 2016, 7:42 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, Joseph Wu, and Till Toenshoff.


Changes
---

Corrected LEVELDB_LIB to point to leveldb library.


Bugs: MESOS-4746
https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description
---

CMAKE: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
0c80fb8d799ea1252492cd98ac0780f1228aadcd 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
3a2e0999722007475c023ade75719093e35cfc80 
  3rdparty/libprocess/cmake/macros/External.cmake 
e3901b67048f1c028216ae8323ee1c318a46f3cc 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds.

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
---

(Updated Feb. 25, 2016, 8:22 a.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, Joseph Wu, and Till Toenshoff.


Changes
---

Corrected LEVELDB_LIB definition.


Summary (updated)
-

CMAKE: Add leveldb library to 3rdparty external builds.


Bugs: MESOS-4746
https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description (updated)
---

CMAKE: Add leveldb library to 3rdparty external builds.


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
0c80fb8d799ea1252492cd98ac0780f1228aadcd 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
3a2e0999722007475c023ade75719093e35cfc80 
  3rdparty/libprocess/cmake/macros/External.cmake 
e3901b67048f1c028216ae8323ee1c318a46f3cc 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120510
---



Bad patch!

Reviews applied: [43889]

Failed command: ./support/apply-review.sh -n -r 43889

Error:
2016-02-24 15:49:24 URL:https://reviews.apache.org/r/43889/diff/raw/ 
[8241/8241] -> "43889.patch" [1]
No files to lint

ERROR: Commit spanning multiple projects.

Please use separate commits for mesos, libprocess and stout.

Paths grouped by project:
libprocess:
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake
  3rdparty/libprocess/cmake/macros/External.cmake
mesos:
  3rdparty/cmake/Mesos3rdpartyConfigure.cmake

Full log: https://builds.apache.org/job/mesos-reviewbot/11632/console

- Mesos ReviewBot


On Feb. 24, 2016, 2:05 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 24, 2016, 2:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[haosdent huang]

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/cmake/macros/External.cmake, line 38
> > 
> >
> > And why we need change `EXTERNAL` macro here? I prososal add a version 
> > to our leveldb.tar.gz
> 
> Diana Arroyo wrote:
> I expect we will need to get an agreement with the folks who maintain the 
> make build.  Who is the person that need to be pulled into this discussion?

I think maybe @tillt


- haosdent


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120353
---


On Feb. 24, 2016, 2:05 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 24, 2016, 2:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[Diana Arroyo]

> On Feb. 23, 2016, 6:22 p.m., haosdent huang wrote:
> > 3rdparty/libprocess/cmake/macros/External.cmake, line 38
> > 
> >
> > And why we need change `EXTERNAL` macro here? I prososal add a version 
> > to our leveldb.tar.gz

I expect we will need to get an agreement with the folks who maintain the make 
build.  Who is the person that need to be pulled into this discussion?


- Diana


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120353
---


On Feb. 24, 2016, 2:05 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 24, 2016, 2:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4746
> https://issues.apache.org/jira/browse/MESOS-4746
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[Diana Arroyo]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/
---

(Updated Feb. 24, 2016, 2:05 p.m.)


Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
Remoortere, and Joseph Wu.


Changes
---

Addressed Alex's Comments


Bugs: MESOS-4746
https://issues.apache.org/jira/browse/MESOS-4746


Repository: mesos


Description
---

CMAKE: Add leveldb library to 3rdparty external builds


Diffs (updated)
-

  3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
0c80fb8d799ea1252492cd98ac0780f1228aadcd 
  3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
  3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
3a2e0999722007475c023ade75719093e35cfc80 
  3rdparty/libprocess/cmake/macros/External.cmake 
e3901b67048f1c028216ae8323ee1c318a46f3cc 

Diff: https://reviews.apache.org/r/43889/diff/


Testing
---

Tested on Ubuntu.


Thanks,

Diana Arroyo

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120386
---



Bad patch!

Reviews applied: [43889]

Failed command: ./support/apply-review.sh -n -r 43889

Error:
2016-02-23 21:11:52 URL:https://reviews.apache.org/r/43889/diff/raw/ 
[8229/8229] -> "43889.patch" [1]
43889.patch:137: trailing whitespace.
 
warning: 1 line adds whitespace errors.
3rdparty/libprocess/cmake/macros/External.cmake:57: trailing whitespace.
+ 

Full log: https://builds.apache.org/job/mesos-reviewbot/11610/console

- Mesos ReviewBot


On Feb. 23, 2016, 6:13 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 23, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4647
> https://issues.apache.org/jira/browse/MESOS-4647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>

Re: Review Request 43889: CMAKE: Add leveldb library to 3rdparty external builds

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43889/#review120349
---



Hi, I think the bug field for this review should be `MESOS-4746`?

- haosdent huang


On Feb. 23, 2016, 6:13 p.m., Diana Arroyo wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43889/
> ---
> 
> (Updated Feb. 23, 2016, 6:13 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Alex Clemmer, Joris Van 
> Remoortere, and Joseph Wu.
> 
> 
> Bugs: MESOS-4647
> https://issues.apache.org/jira/browse/MESOS-4647
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> CMAKE: Add leveldb library to 3rdparty external builds
> 
> 
> Diffs
> -
> 
>   3rdparty/cmake/Mesos3rdpartyConfigure.cmake 
> 0c80fb8d799ea1252492cd98ac0780f1228aadcd 
>   3rdparty/libprocess/cmake/Process3rdpartyConfigure.cmake 
> d36fa2fbe903fb278e6c00b47bfa4b81cf8f4673 
>   3rdparty/libprocess/cmake/ProcessTestsConfigure.cmake 
> 3a2e0999722007475c023ade75719093e35cfc80 
>   3rdparty/libprocess/cmake/macros/External.cmake 
> e3901b67048f1c028216ae8323ee1c318a46f3cc 
> 
> Diff: https://reviews.apache.org/r/43889/diff/
> 
> 
> Testing
> ---
> 
> Tested on Ubuntu.
> 
> 
> Thanks,
> 
> Diana Arroyo
> 
>