Re: Review Request 43956: Created base docker image for test suite.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/
---

(Updated March 11, 2016, 4:15 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4684
https://issues.apache.org/jira/browse/MESOS-4684


Repository: mesos


Description
---

Created base docker image for test suite.


Diffs (updated)
-

  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/tests/containerizer/docker_archive.hpp PRE-CREATION 
  src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43956/diff/


Testing
---

(Ubuntu14.04 + clang-3.6)

make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 

sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"


Thanks,

Gilbert Song

Re: Review Request 43956: Created base docker image for test suite.

[haosdent huang]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review123173
---




src/tests/containerizer/docker_archive.hpp (line 169)


We don't need clear anyfiles we created before once failed, right?



src/tests/containerizer/docker_archive.hpp (line 212)


Do we need pass a value to avoid it await forever? Above code also have 
another tarRootfs.await()


- haosdent huang


On March 10, 2016, 11:37 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> ---
> 
> (Updated March 10, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created base docker image for test suite.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/tests/containerizer/docker_archive.hpp PRE-CREATION 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43956/diff/
> 
> 
> Testing
> ---
> 
> (Ubuntu14.04 + clang-3.6)
> 
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43956: Created base docker image for test suite.

[Gilbert Song]

> On March 10, 2016, 6:22 p.m., Jie Yu wrote:
> >

I think we should not use `Option` here, because in a docker manifest, 
it does not exist None case. If any field does not exist, it should be 
JSON::null. Entrypoint/cmd should be either JSON::null or a JSON::array `["a", 
"b", ...]`. 

So we should change these parameters back to `string`.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review123068
---


On March 10, 2016, 3:37 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> ---
> 
> (Updated March 10, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created base docker image for test suite.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/tests/containerizer/docker_archive.hpp PRE-CREATION 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43956/diff/
> 
> 
> Testing
> ---
> 
> (Ubuntu14.04 + clang-3.6)
> 
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43956: Created base docker image for test suite.

[Jie Yu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review123068
---


Fix it, then Ship it!





src/tests/containerizer/docker_archive.hpp (lines 54 - 55)


Default should be None?



src/tests/containerizer/docker_archive.hpp (lines 153 - 154)


What if 'entrypoint' or 'cmd' is none?


- Jie Yu


On March 10, 2016, 11:37 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> ---
> 
> (Updated March 10, 2016, 11:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created base docker image for test suite.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/tests/containerizer/docker_archive.hpp PRE-CREATION 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43956/diff/
> 
> 
> Testing
> ---
> 
> (Ubuntu14.04 + clang-3.6)
> 
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43956: Created base docker image for test suite.

[Gilbert Song]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/
---

(Updated March 10, 2016, 3:37 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4684
https://issues.apache.org/jira/browse/MESOS-4684


Repository: mesos


Description
---

Created base docker image for test suite.


Diffs (updated)
-

  src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
  src/tests/containerizer/docker_archive.hpp PRE-CREATION 
  src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/43956/diff/


Testing
---

(Ubuntu14.04 + clang-3.6)

make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 

sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"


Thanks,

Gilbert Song

Re: Review Request 43956: Created base docker image for test suite.

[Gilbert Song]

> On March 8, 2016, 6:57 p.m., Guangya Liu wrote:
> > src/tests/containerizer/docker_archive.hpp, lines 70-75
> > 
> >
> > Two layer will not work with bind backend, does it make sense to enable 
> > `create` can specify if only want one layer?
> > 
> > I think that supportting two cases is enough: one layer image and two 
> > layers iamge.
> > 
> > static Future create(
> > const std::string& directory,
> > const std::string& name,
> > const std::string& entrypoint = "null",
> > const std::string& cmd = "null",
> > const bool onelayer = false)

Thanks, Guangya. I just make it `alpine`. )


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review122662
---


On March 10, 2016, 3:37 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> ---
> 
> (Updated March 10, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created base docker image for test suite.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/tests/containerizer/docker_archive.hpp PRE-CREATION 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43956/diff/
> 
> 
> Testing
> ---
> 
> (Ubuntu14.04 + clang-3.6)
> 
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>

Re: Review Request 43956: Created base docker image for test suite.

[Gilbert Song]

> On March 9, 2016, 2:59 p.m., Jie Yu wrote:
> > Can you also update cmakelist?

cmakelist not supports test build yet.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43956/#review122825
---


On March 10, 2016, 3:37 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43956/
> ---
> 
> (Updated March 10, 2016, 3:37 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4684
> https://issues.apache.org/jira/browse/MESOS-4684
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Created base docker image for test suite.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am b24f0f58fa188c16770fe6a3c23ec06262cb0955 
>   src/tests/containerizer/docker_archive.hpp PRE-CREATION 
>   src/tests/containerizer/runtime_isolator_tests.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/43956/diff/
> 
> 
> Testing
> ---
> 
> (Ubuntu14.04 + clang-3.6)
> 
> make -j24 check GTEST_FILTER="*ROOT_RUNTIME_CreateDockerLocalTar*" 
> 
> sudo ./bin/mesos-tests.sh --gtest_filter="*ROOT_RUNTIME_CreateDockerLocalTar*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>