Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-29 Thread James Peach
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review121264 --- Ship it! This looks fine to me. I think it would help future

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review121056 --- Patch looks great! Reviews applied: [43999] Passed command:

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Zhiwei Chen
> On Feb. 27, 2016, 1:36 a.m., Kapil Arya wrote: > > src/Makefile.am, lines 2010-2011 > > > > > > Minor nit. Can we fix the alignment to four spaces to be consistent > > with the rest of the block? Also align the

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/ --- (Updated Feb. 27, 2016, 9:55 a.m.) Review request for mesos, James Peach and

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Jacob Janco
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review121033 --- Ship it! ran a patched version through our pipeline and our

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Kapil Arya
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review120894 --- Fix it, then Ship it! I'll fix it for you and commit it

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-26 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/#review120856 --- Patch looks great! Reviews applied: [43999] Passed command:

Re: Review Request 43999: Use relative path to create libraries symbolic link.

2016-02-25 Thread Zhiwei Chen
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/43999/ --- (Updated Feb. 26, 2016, 9:59 a.m.) Review request for mesos. Bugs: