Re: Review Request 43999: Use relative path to create libraries symbolic link.

[James Peach]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review121264
---


Ship it!




This looks fine to me. I think it would help future generations to add a 
comment about where the relative paths actually point to and constructing this 
path is safe.

- James Peach


On Feb. 27, 2016, 1:55 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> ---
> 
> (Updated Feb. 27, 2016, 1:55 a.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
> https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> ---
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43999: Use relative path to create libraries symbolic link.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review121056
---



Patch looks great!

Reviews applied: [43999]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 27, 2016, 1:55 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> ---
> 
> (Updated Feb. 27, 2016, 1:55 a.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
> https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> ---
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43999: Use relative path to create libraries symbolic link.

[Zhiwei Chen]

> On Feb. 27, 2016, 1:36 a.m., Kapil Arya wrote:
> > src/Makefile.am, lines 2010-2011
> > 
> >
> > Minor nit. Can we fix the alignment to four spaces to be consistent 
> > with the rest of the block? Also align the trailing slashes? (It's possible 
> > that they are already aligned, just not showing up on the RB diff.

Thanks, it was aligned in git diff.


- Zhiwei


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review120894
---


On Feb. 26, 2016, 4:18 p.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> ---
> 
> (Updated Feb. 26, 2016, 4:18 p.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
> https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> ---
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43999: Use relative path to create libraries symbolic link.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/
---

(Updated Feb. 27, 2016, 9:55 a.m.)


Review request for mesos, James Peach and Kapil Arya.


Bugs: MESOS-4774
https://issues.apache.org/jira/browse/MESOS-4774


Repository: mesos


Description
---

Use relative path to create libraries symbolic link.


Diffs (updated)
-

  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 

Diff: https://reviews.apache.org/r/43999/diff/


Testing
---

After make install, the library links will be relative path.


Thanks,

Zhiwei Chen

Re: Review Request 43999: Use relative path to create libraries symbolic link.

[Jacob Janco]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review121033
---


Ship it!




ran a patched version through our pipeline and our rpm builds look good, thanks!

- Jacob Janco


On Feb. 26, 2016, 8:18 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> ---
> 
> (Updated Feb. 26, 2016, 8:18 a.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
> https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> ---
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43999: Use relative path to create libraries symbolic link.

[Kapil Arya]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review120894
---


Fix it, then Ship it!




I'll fix it for you and commit it shortly.


src/Makefile.am (lines 2010 - 2011)


Minor nit. Can we fix the alignment to four spaces to be consistent with 
the rest of the block? Also align the trailing slashes? (It's possible that 
they are already aligned, just not showing up on the RB diff.


- Kapil Arya


On Feb. 26, 2016, 3:18 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> ---
> 
> (Updated Feb. 26, 2016, 3:18 a.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
> https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> ---
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43999: Use relative path to create libraries symbolic link.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/#review120856
---



Patch looks great!

Reviews applied: [43999]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 26, 2016, 8:18 a.m., Zhiwei Chen wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43999/
> ---
> 
> (Updated Feb. 26, 2016, 8:18 a.m.)
> 
> 
> Review request for mesos, James Peach and Kapil Arya.
> 
> 
> Bugs: MESOS-4774
> https://issues.apache.org/jira/browse/MESOS-4774
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Use relative path to create libraries symbolic link.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
> 
> Diff: https://reviews.apache.org/r/43999/diff/
> 
> 
> Testing
> ---
> 
> After make install, the library links will be relative path.
> 
> 
> Thanks,
> 
> Zhiwei Chen
> 
>

Re: Review Request 43999: Use relative path to create libraries symbolic link.

[Zhiwei Chen]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43999/
---

(Updated Feb. 26, 2016, 9:59 a.m.)


Review request for mesos.


Bugs: MESOS-4774
https://issues.apache.org/jira/browse/MESOS-4774


Repository: mesos


Description
---

Use relative path to create libraries symbolic link.


Diffs
-

  src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 

Diff: https://reviews.apache.org/r/43999/diff/


Testing (updated)
---

After make install, the library links will be relative path.


Thanks,

Zhiwei Chen