Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-28 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/#review121151
---


Ship it!




Ship It!

- Klaus Ma


On Feb. 27, 2016, 8:55 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44110/
> ---
> 
> (Updated Feb. 27, 2016, 8:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-4509
> https://issues.apache.org/jira/browse/MESOS-4509
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated flag examples to refer to /role instead of stats.json.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
> 
> Diff: https://reviews.apache.org/r/44110/diff/
> 
> 
> Testing
> ---
> 
> make test + manually checked the flags example.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/#review121025
---


Ship it!




Ship It!

- Neil Conway


On Feb. 27, 2016, 12:55 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44110/
> ---
> 
> (Updated Feb. 27, 2016, 12:55 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-4509
> https://issues.apache.org/jira/browse/MESOS-4509
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated flag examples to refer to /role instead of stats.json.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
> 
> Diff: https://reviews.apache.org/r/44110/diff/
> 
> 
> Testing
> ---
> 
> make test + manually checked the flags example.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/
---

(Updated Feb. 27, 2016, 12:55 a.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Changes
---

Addressed comment.


Bugs: MESOS-4509
https://issues.apache.org/jira/browse/MESOS-4509


Repository: mesos


Description
---

Updated flag examples to refer to /role instead of stats.json.


Diffs (updated)
-

  docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
  src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 

Diff: https://reviews.apache.org/r/44110/diff/


Testing
---

make test + manually checked the flags example.


Thanks,

Joerg Schad

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/#review121017
---




docs/configuration.md (line 86)


Is this a valid endpoint? "/roles" is a master endpoint but not an agent 
endpoint AFAIK.


- Neil Conway


On Feb. 27, 2016, 12:33 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44110/
> ---
> 
> (Updated Feb. 27, 2016, 12:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-4509
> https://issues.apache.org/jira/browse/MESOS-4509
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated flag examples to refer to /role instead of stats.json.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
> 
> Diff: https://reviews.apache.org/r/44110/diff/
> 
> 
> Testing
> ---
> 
> make test + manually checked the flags example.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/
---

(Updated Feb. 27, 2016, 12:33 a.m.)


Review request for mesos, Alexander Rojas and Vinod Kone.


Bugs: MESOS-4509
https://issues.apache.org/jira/browse/MESOS-4509


Repository: mesos


Description (updated)
---

Updated flag examples to refer to /role instead of stats.json.


Diffs (updated)
-

  docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
  src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 

Diff: https://reviews.apache.org/r/44110/diff/


Testing
---

make test + manually checked the flags example.


Thanks,

Joerg Schad

Re: Review Request 44110: Updated flag examples to refer to /role instead of stats.json.

2016-02-26 Thread Alexander Rojas 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44110/#review121016
---


Ship it!




Ship It!

- Alexander Rojas


On Feb. 27, 2016, 1:33 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44110/
> ---
> 
> (Updated Feb. 27, 2016, 1:33 a.m.)
> 
> 
> Review request for mesos, Alexander Rojas and Vinod Kone.
> 
> 
> Bugs: MESOS-4509
> https://issues.apache.org/jira/browse/MESOS-4509
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Updated flag examples to refer to /role instead of stats.json.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md 2353e78a80548b63f871c52e840ffe2fe869f4d7 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
>   src/slave/flags.cpp 1c6a87b670efde2deab4d6e3f24fd6eb3704a47d 
> 
> Diff: https://reviews.apache.org/r/44110/diff/
> 
> 
> Testing
> ---
> 
> make test + manually checked the flags example.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>