Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

[Yi Sun]

> On March 1, 2016, 11:47 p.m., Yi Sun wrote:
> > 3rdparty/libprocess/src/windows/subprocess.cpp, line 152
> > 
> >
> > The second param for strcpy_s is the number of chars to be copied. It 
> > doesn't seem right here.

It's the size of the dest buffer. I got it wrong.


- Yi


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44141/#review121541
---


On March 1, 2016, 8:58 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44141/
> ---
> 
> (Updated March 1, 2016, 8:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 12dfaf61b801372b6ec70c535080fde350866fb8 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44141/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

[Yi Sun]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44141/#review121543
---


Ship it!




Ship It!

- Yi Sun


On March 1, 2016, 8:58 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44141/
> ---
> 
> (Updated March 1, 2016, 8:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 12dfaf61b801372b6ec70c535080fde350866fb8 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44141/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>

Re: Review Request 44141: Windows: Forked subprocess.cpp, added `Windows` implementation.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44141/#review121540
---



Bad patch!

Reviews applied: [44141, 44140]

Failed command: ./support/apply-review.sh -n -r 44140

Error:
2016-03-01 23:23:40 URL:https://reviews.apache.org/r/44140/diff/raw/ 
[3115/3115] -> "44140.patch" [1]
error: patch failed: 3rdparty/libprocess/src/process.cpp:2195
error: 3rdparty/libprocess/src/process.cpp: patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/11767/console

- Mesos ReviewBot


On March 1, 2016, 8:58 p.m., Daniel Pravat wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44141/
> ---
> 
> (Updated March 1, 2016, 8:58 p.m.)
> 
> 
> Review request for mesos, Alex Naparu, Daniel Pravat, Artem Harutyunyan, 
> Joris Van Remoortere, Michael Park, M Lawindi, and Yi Sun.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Windows: Forked subprocess.cpp, added `Windows` implementation.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/Makefile.am ac8cc8d29baccf6e3a17367540ddd1f28585ef6d 
>   3rdparty/libprocess/include/process/subprocess.hpp 
> e0c306aa5cf5f393abb73768bbd287c45730f076 
>   3rdparty/libprocess/src/CMakeLists.txt 
> 12dfaf61b801372b6ec70c535080fde350866fb8 
>   3rdparty/libprocess/src/subprocess.cpp 
> 44ca6d0869f3dbcfda1ac01d0d6b79dc20c4267c 
>   3rdparty/libprocess/src/subprocess_posix.cpp PRE-CREATION 
>   3rdparty/libprocess/src/subprocess_windows.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44141/diff/
> 
> 
> Testing
> ---
> 
> OSX: make check
> Windows: build/run
> 
> 
> Thanks,
> 
> Daniel Pravat
> 
>