Re: Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

2016-02-28 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44147/#review121168
---


Ship it!




Ship It!

- Neil Conway


On Feb. 28, 2016, 7:36 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44147/
> ---
> 
> (Updated Feb. 28, 2016, 7:36 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4792
> https://issues.apache.org/jira/browse/MESOS-4792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove unused src/common/date_utils.{c,h}pp (MESOS-4792).
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/common/date_utils.hpp 794510c0f31eab6dafe8b86d835710096aac3392 
>   src/common/date_utils.cpp 64eb33fee0c6155db3d6bcd3086bfcf4d7d9f7c0 
>   src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
> 
> Diff: https://reviews.apache.org/r/44147/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>



Re: Review Request 44147: Remove unused src/common/date_utils.{c, h}pp (MESOS-4792).

2016-02-28 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44147/#review121164
---



Patch looks great!

Reviews applied: [44147]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 28, 2016, 7:36 p.m., Yong Tang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44147/
> ---
> 
> (Updated Feb. 28, 2016, 7:36 p.m.)
> 
> 
> Review request for mesos and Neil Conway.
> 
> 
> Bugs: MESOS-4792
> https://issues.apache.org/jira/browse/MESOS-4792
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Remove unused src/common/date_utils.{c,h}pp (MESOS-4792).
> 
> 
> Diffs
> -
> 
>   src/CMakeLists.txt 49a5645ef7242dbaee31e7b26dbbcb1f4f1f910e 
>   src/Makefile.am 2a26261b513bb7c03437ed8e850c3b36b93d82f5 
>   src/common/date_utils.hpp 794510c0f31eab6dafe8b86d835710096aac3392 
>   src/common/date_utils.cpp 64eb33fee0c6155db3d6bcd3086bfcf4d7d9f7c0 
>   src/master/master.cpp 7c62f2a882a1c89d73f328b2ae665422fd84d7a1 
> 
> Diff: https://reviews.apache.org/r/44147/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Yong Tang
> 
>