Re: Review Request 44185: Clarified docs for `--offer_timeout` master flag.

2016-03-01 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44185/#review121501
---


Ship it!




Ship It!

- Vinod Kone


On Feb. 29, 2016, 11:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44185/
> ---
> 
> (Updated Feb. 29, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4702
> https://issues.apache.org/jira/browse/MESOS-4702
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified docs for `--offer_timeout` master flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
> 
> Diff: https://reviews.apache.org/r/44185/diff/
> 
> 
> Testing
> ---
> 
> Compiled on OSX.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 44185: Clarified docs for `--offer_timeout` master flag.

2016-02-29 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44185/#review121369
---



Patch looks great!

Reviews applied: [44185]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 29, 2016, 11:34 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44185/
> ---
> 
> (Updated Feb. 29, 2016, 11:34 p.m.)
> 
> 
> Review request for mesos and Vinod Kone.
> 
> 
> Bugs: MESOS-4702
> https://issues.apache.org/jira/browse/MESOS-4702
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Clarified docs for `--offer_timeout` master flag.
> 
> 
> Diffs
> -
> 
>   docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
>   src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 
> 
> Diff: https://reviews.apache.org/r/44185/diff/
> 
> 
> Testing
> ---
> 
> Compiled on OSX.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>



Re: Review Request 44185: Clarified docs for `--offer_timeout` master flag.

2016-02-29 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44185/
---

(Updated Feb. 29, 2016, 11:34 p.m.)


Review request for mesos and Vinod Kone.


Bugs: MESOS-4702
https://issues.apache.org/jira/browse/MESOS-4702


Repository: mesos


Description
---

Clarified docs for `--offer_timeout` master flag.


Diffs
-

  docs/configuration.md c4d094aac4acb95fd6648071413a3d5160dbf381 
  src/master/flags.cpp 60e085bd5c6689adb625a736edc76e814860ea7d 

Diff: https://reviews.apache.org/r/44185/diff/


Testing
---

Compiled on OSX.


Thanks,

Neil Conway