Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

2016-03-02 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/#review121640
---



Patch looks great!

Reviews applied: [44254]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 2, 2016, 6:21 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44254/
> ---
> 
> (Updated March 2, 2016, 6:21 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When fopen is failed,we should curl_easy_cleanup curl_handle and close fd
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 
> 
> Diff: https://reviews.apache.org/r/44254/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

2016-03-01 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/#review121595
---


Ship it!




Ship It!

- Klaus Ma


On March 2, 2016, 2:21 p.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44254/
> ---
> 
> (Updated March 2, 2016, 2:21 p.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When fopen is failed,we should curl_easy_cleanup curl_handle and close fd
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 
> 
> Diff: https://reviews.apache.org/r/44254/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

2016-03-01 Thread Andy Pang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/
---

(Updated 三月 2, 2016, 6:21 a.m.)


Review request for mesos, Jie Yu and Vinod Kone.


Repository: mesos


Description (updated)
---

When fopen is failed,we should curl_easy_cleanup curl_handle and close fd


Diffs (updated)
-

  3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 

Diff: https://reviews.apache.org/r/44254/diff/


Testing
---

make check


Thanks,

Andy Pang

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

2016-03-01 Thread Klaus Ma 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/#review121587
---




3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp (line 159)


also close fd (`os::close(fd.get())`)


- Klaus Ma


On March 2, 2016, 11:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44254/
> ---
> 
> (Updated March 2, 2016, 11:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When fopen is failed,we should curl_easy_cleanup curl_handle.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 
> 
> Diff: https://reviews.apache.org/r/44254/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>

Re: Review Request 44254: Add curl_easy_cleanup when fopen is failed.

2016-03-01 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44254/#review121582
---


Ship it!




Could you create a jira ticket for this?

- haosdent huang


On March 2, 2016, 3:45 a.m., Andy Pang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44254/
> ---
> 
> (Updated March 2, 2016, 3:45 a.m.)
> 
> 
> Review request for mesos, Jie Yu and Vinod Kone.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> When fopen is failed,we should curl_easy_cleanup curl_handle.
> 
> 
> Diffs
> -
> 
>   3rdparty/libprocess/3rdparty/stout/include/stout/net.hpp 3c80910 
> 
> Diff: https://reviews.apache.org/r/44254/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Andy Pang
> 
>