Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

2016-03-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/ --- (Updated March 3, 2016, 5:17 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

2016-03-03 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/ --- (Updated March 3, 2016, 2:11 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

2016-03-02 Thread Benjamin Bannier
> On March 2, 2016, 2:52 p.m., Alexander Rukletsov wrote: > > 3rdparty/libprocess/include/process/metrics/timer.hpp, line 147 > > > > > > I don't think we put non-empty function body on the same line. In fact we do

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

2016-03-02 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/ --- (Updated March 2, 2016, 4:43 p.m.) Review request for mesos, Alexander Rukletso

Re: Review Request 44261: Introduced a RAII helper for process::metrics::Timer.

2016-03-02 Thread Alexander Rukletsov
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44261/#review121635 --- Fix it, then Ship it! 3rdparty/libprocess/include/process/metr