Re: Review Request 44319: Removed initialize method from the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/#review123210 --- Ship it! Ship It! - Vinod Kone On March 11, 2016, 1:45

Re: Review Request 44319: Removed initialize method from the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/ --- (Updated March 11, 2016, 2:45 p.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44319: Removed initialize method from the authorizer interface.

> On March 10, 2016, 8:32 p.m., Vinod Kone wrote: > > src/master/main.cpp, line 372 > > > > > > So, we create non-default authorizer if --authorizers specifies a > > non-default name but create the default

Re: Review Request 44319: Removed initialize method from the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/#review122961 --- Fix it, then Ship it! Looks good. Some minor comments.

Re: Review Request 44319: Removed initialize method from the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/ --- (Updated March 9, 2016, 5:54 a.m.) Review request for mesos, Adam B, Joerg

Re: Review Request 44319: Removed initialize method from the authorizer interface.

> On March 8, 2016, 7:16 p.m., Vinod Kone wrote: > > src/examples/test_authorizer_module.cpp, lines 41-61 > > > > > > why can't you use Authorizer::create() here instead of repeating this > > flags

Re: Review Request 44319: Removed initialize method from the authorizer interface.

> On March 8, 2016, 1:08 a.m., Vinod Kone wrote: > > include/mesos/authorizer/authorizer.hpp, line 58 > > > > > > seems weird that this interface takes ACLs as a param. can we make it > > take Parameters instead? I

Re: Review Request 44319: Removed initialize method from the authorizer interface.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44319/ --- (Updated March 8, 2016, 5:43 p.m.) Review request for mesos, Adam B, Joerg