Re: Review Request 44334: Cleaned up empty hashmaps from allocator tests.

2016-04-13 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44334/#review128631 --- Fix it, then Ship it!

Re: Review Request 44334: Cleaned up empty hashmaps from allocator tests.

2016-04-13 Thread Benjamin Bannier
> On March 4, 2016, 12:59 p.m., Bernd Mathiske wrote: > > "{}" is short, but cryptic. It is unclear what kind of entity is being > > passed here. "EMPTY" was not any better. "hashmap()" at > > least revealed the type which hinted a little at the presumable purpose. A > >

Re: Review Request 44334: Cleaned up empty hashmaps from allocator tests.

2016-03-07 Thread Alexander Rukletsov
> On March 4, 2016, 11:59 a.m., Bernd Mathiske wrote: > > "{}" is short, but cryptic. It is unclear what kind of entity is being > > passed here. "EMPTY" was not any better. "hashmap()" at > > least revealed the type which hinted a little at the presumable purpose. A > >

Re: Review Request 44334: Cleaned up empty hashmaps from allocator tests.

2016-03-04 Thread Bernd Mathiske
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44334/#review122058 --- "{}" is short, but cryptic. It is unclear what kind of entity is