Re: Review Request 44370: Fixed incorrect http authenticator module type.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44370/#review131794
---
Ship it!
Ship It!
- Adam B
On March 3, 2016, 4:14 p.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44370/
> ---
>
> (Updated March 3, 2016, 4:14 p.m.)
>
>
> Review request for mesos and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> see summary.
>
>
> Diffs
> -
>
> src/master/master.cpp 2be954d04ab9ba329bac95d815637caf557339cc
>
> Diff: https://reviews.apache.org/r/44370/diff/
>
>
> Testing
> ---
>
> make check & functional testing
>
> Modules definition:
> ```
> --modules="libraries {
> file: "/somewhere/libtills_awesome_http_authenticator.dylib"
> modules {
> name: "tills_awesome_auth_module"
> parameters {
> key: "foo"
> value: "bar"
> }
> }
> }
> ```
>
> Before applying this patch.
>
> Resulting in:
> ```
> HTTP authenticator 'tills_awesome_auth_module' not found. Check the spelling
> (compare to 'basic'') or verify that the authenticator was loaded
> successfully (see --modules)
> ```
>
> After applying this patch, resulting in:
> ```
> I0304 00:49:45.259122 1064960 master.cpp:555] Using
> 'tills_awesome_auth_module' HTTP authenticator
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 44370: Fixed incorrect http authenticator module type.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44370/#review122034
---
Patch looks great!
Reviews applied: [44370]
Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose'
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh
- Mesos ReviewBot
On March 4, 2016, 12:14 a.m., Till Toenshoff wrote:
>
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44370/
> ---
>
> (Updated March 4, 2016, 12:14 a.m.)
>
>
> Review request for mesos and Alexander Rojas.
>
>
> Repository: mesos
>
>
> Description
> ---
>
> see summary.
>
>
> Diffs
> -
>
> src/master/master.cpp 2be954d04ab9ba329bac95d815637caf557339cc
>
> Diff: https://reviews.apache.org/r/44370/diff/
>
>
> Testing
> ---
>
> make check & functional testing
>
> Modules definition:
> ```
> --modules="libraries {
> file: "/somewhere/libtills_awesome_http_authenticator.dylib"
> modules {
> name: "tills_awesome_auth_module"
> parameters {
> key: "foo"
> value: "bar"
> }
> }
> }
> ```
>
> Before applying this patch.
>
> Resulting in:
> ```
> HTTP authenticator 'tills_awesome_auth_module' not found. Check the spelling
> (compare to 'basic'') or verify that the authenticator was loaded
> successfully (see --modules)
> ```
>
> After applying this patch, resulting in:
> ```
> I0304 00:49:45.259122 1064960 master.cpp:555] Using
> 'tills_awesome_auth_module' HTTP authenticator
> ```
>
>
> Thanks,
>
> Till Toenshoff
>
>
Re: Review Request 44370: Fixed incorrect http authenticator module type.
---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44370/
---
(Updated March 4, 2016, 12:14 a.m.)
Review request for mesos and Alexander Rojas.
Repository: mesos
Description
---
see summary.
Diffs
-
src/master/master.cpp 2be954d04ab9ba329bac95d815637caf557339cc
Diff: https://reviews.apache.org/r/44370/diff/
Testing (updated)
---
make check & functional testing
Modules definition:
```
--modules="libraries {
file: "/somewhere/libtills_awesome_http_authenticator.dylib"
modules {
name: "tills_awesome_auth_module"
parameters {
key: "foo"
value: "bar"
}
}
}
```
Before applying this patch.
Resulting in:
```
HTTP authenticator 'tills_awesome_auth_module' not found. Check the spelling
(compare to 'basic'') or verify that the authenticator was loaded successfully
(see --modules)
```
After applying this patch, resulting in:
```
I0304 00:49:45.259122 1064960 master.cpp:555] Using 'tills_awesome_auth_module'
HTTP authenticator
```
Thanks,
Till Toenshoff
Re: Review Request 44370: Fixed incorrect http authenticator module type.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44370/#review121965 --- Ship it! Ship It! - Alexander Rojas On March 4, 2016, 1:05 a.m., Till Toenshoff wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44370/ > --- > > (Updated March 4, 2016, 1:05 a.m.) > > > Review request for mesos and Alexander Rojas. > > > Repository: mesos > > > Description > --- > > see summary. > > > Diffs > - > > src/master/master.cpp 2be954d04ab9ba329bac95d815637caf557339cc > > Diff: https://reviews.apache.org/r/44370/diff/ > > > Testing > --- > > make check > > > Thanks, > > Till Toenshoff > >
