Re: Review Request 44423: Added HTTP command executor to make files.

2016-04-13 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44423/
---

(Updated April 13, 2016, 9:30 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description (updated)
---

Added HTTP command executor to make files. For now the content in 
http_command_executor.cpp is identical to executor.cpp, and it 
will be updated in the subsequent review.


Diffs
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/launcher/http_command_executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44423/diff/


Testing
---

Make check


Thanks,

Qian Zhang



Re: Review Request 44423: Added HTTP command executor to make files.

2016-04-03 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44423/
---

(Updated April 3, 2016, 8:51 p.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Changes
---

Updated the code based on the latest command executor.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description
---

Added HTTP command executor to make files. For now the content in 
http_command_executor.cpp is identical to executor.cpp, and it will be updated 
in the subsequent review.


Diffs (updated)
-

  src/Makefile.am f22ae5b3bd9336a56c802e0e51d39d6cb675caf2 
  src/launcher/http_command_executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44423/diff/


Testing
---

Make check


Thanks,

Qian Zhang



Re: Review Request 44423: Added HTTP command executor to make files.

2016-03-06 Thread Qian Zhang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44423/
---

(Updated March 7, 2016, 8:04 a.m.)


Review request for mesos, Anand Mazumdar and Vinod Kone.


Bugs: MESOS-3558
https://issues.apache.org/jira/browse/MESOS-3558


Repository: mesos


Description (updated)
---

Added HTTP command executor to make files. For now the content in 
http_command_executor.cpp is identical to executor.cpp, and it will be updated 
in the subsequent review.


Diffs
-

  src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
  src/launcher/http_command_executor.cpp PRE-CREATION 

Diff: https://reviews.apache.org/r/44423/diff/


Testing
---

Make check


Thanks,

Qian Zhang



Re: Review Request 44423: Added HTTP command executor to make files.

2016-03-06 Thread Qian Zhang


> On March 6, 2016, 11:59 p.m., Vinod Kone wrote:
> > Can you update the description saying that for now the content in 
> > http_command_executor.cpp is identical to executor.cpp and that it will 
> > updated in the subsequent review?

Sure.


- Qian


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44423/#review122232
---


On March 5, 2016, 11:02 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44423/
> ---
> 
> (Updated March 5, 2016, 11:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP command executor to make files.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44423/diff/
> 
> 
> Testing
> ---
> 
> Make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>



Re: Review Request 44423: Added HTTP command executor to make files.

2016-03-06 Thread Vinod Kone

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44423/#review122232
---


Ship it!




Can you update the description saying that for now the content in 
http_command_executor.cpp is identical to executor.cpp and that it will updated 
in the subsequent review?

- Vinod Kone


On March 5, 2016, 3:02 p.m., Qian Zhang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44423/
> ---
> 
> (Updated March 5, 2016, 3:02 p.m.)
> 
> 
> Review request for mesos, Anand Mazumdar and Vinod Kone.
> 
> 
> Bugs: MESOS-3558
> https://issues.apache.org/jira/browse/MESOS-3558
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added HTTP command executor to make files.
> 
> 
> Diffs
> -
> 
>   src/Makefile.am a41e95ddeb838fdebf4ced953c4a29181916e261 
>   src/launcher/http_command_executor.cpp PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44423/diff/
> 
> 
> Testing
> ---
> 
> Make check
> 
> 
> Thanks,
> 
> Qian Zhang
> 
>