Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-25 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 25, 2016, 8:20 a.m.) Review request for mesos, Adam B and

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-25 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review125394 --- Fix it, then Ship it! Let's agree to remove the below check

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-23 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review124997 --- Patch looks great! Reviews applied: [44450] Passed command:

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-23 Thread Yongqiao Wang
> On March 21, 2016, 8 a.m., Adam B wrote: > > Could you write a test where one framework hoards its share of the > > resources (doesn't accept/decline them), then weights are updated to > > increase another framework's share, and the other framework actually gets > > offers to cover its

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-22 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 23, 2016, 1:59 a.m.) Review request for mesos, Adam B and

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-22 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review124791 --- Patch looks great! Reviews applied: [41681, 43863, 44450]

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-21 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 22, 2016, 5:50 a.m.) Review request for mesos, Adam B and

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review124509 --- Could you write a test where one framework hoards its share of

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-14 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review123454 --- Patch looks great! Reviews applied: [41681, 43863, 44450]

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-14 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 14, 2016, 2:07 p.m.) Review request for mesos, Adam B and

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-14 Thread Adam B
> On March 14, 2016, 12:50 a.m., Adam B wrote: > > Looks pretty good to me, but I'd like to get AlexR to take a look over it. > > Also, do we need to rescind inverse offers here too? I'm guessing not, but > > I'd like somebody to confirm. And let's do the tests in the same JIRA, but a

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-14 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review123364 --- Looks pretty good to me, but I'd like to get AlexR to take a look

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-09 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review122711 --- Patch looks great! Reviews applied: [41681, 43863, 44450]

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-08 Thread Yongqiao Wang
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/ --- (Updated March 9, 2016, 5:19 a.m.) Review request for mesos and Adam B.

Re: Review Request 44450: Rescind all outstanding offers to satisfy weights update.

2016-03-07 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44450/#review122309 --- Patch looks great! Reviews applied: [41681, 44450] Passed