Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-24 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130321
---


Ship it!




Ship It!

- Jie Yu


On April 24, 2016, 9:56 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 24, 2016, 9:56 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-24 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/
---

(Updated 四月 24, 2016, 9:56 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Changes
---

Rebase


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Enabled Sequence mount for prepare().


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/44454/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130253
---



Patch looks great!

Reviews applied: [45377, 45370, 45375, 45674, 44454]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On April 23, 2016, 8:37 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 23, 2016, 8:37 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-23 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/
---

(Updated 四月 23, 2016, 8:37 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Enabled Sequence mount for prepare().


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/44454/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-23 Thread Mesos ReviewBot 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130251
---



Bad patch!

Reviews applied: [44454, 45370, 45377]

Failed command: ./support/apply-review.sh -n -r 44454

Error:
2016-04-23 08:08:20 URL:https://reviews.apache.org/r/44454/diff/raw/ 
[3213/3213] -> "44454.patch" [1]
error: patch failed: 
src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp:87
error: src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp: 
patch does not apply
error: patch failed: 
src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp:241
error: src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp: 
patch does not apply

Full log: https://builds.apache.org/job/mesos-reviewbot/12685/console

- Mesos ReviewBot


On April 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Jie Yu 


> On April 22, 2016, 9:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109
> > 
> >
> > Please use a Sequence for each DockerVolume. umount A and mount B can 
> > happen in parallel as the ordering does not matter.
> 
> Guangya Liu wrote:
> One question is if define `sequence` for each volume, then can we 
> guarantee that two different volumes can always keep the order?
> 
> e.g.
> Volume 1) driver: convoy, name: dvd1
> Volume 2) driver: flocker, name: dvd2
> 
> One container using the above two different volumes, can we guarantee 
> volume 1 mount point return first than volume 2 if letting differene sequence 
> manage those two volumes?
> 
> Jie Yu wrote:
> why does that matter?
> 
> Guangya Liu wrote:
> For such case:
> 
> Volume 1) driver: convoy, name: dvd1
> Volume 2) driver: flocker, name: dvd2
> 
> Volume 1 map to /tmp/abc1
> Volume 2 map to /tmp/abc2
> 
> If the return value of volume 1 and 2 mount point is not right, then 
> volume 1 mount point will mount to /tmp/abc1 and volume 2 will mount to 
> /tmp/abc2
> 
> I'm just not sure if using different volume sequence can guarantee the 
> order?
> 
> Guangya Liu wrote:
> Correct a typo: If the return value of volume 1 and 2 mount point is not 
> right, then volume 1 mount point will mount to `/tmp/abc2` and volume 2 will 
> mount to `/tmp/abc1`

I don't think that's an issue. I don't think a driver will return an incorrect 
mount point for a volume (otherwise, it's a bug).


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130192
---


On April 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu 


> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109
> > 
> >
> > Please use a Sequence for each DockerVolume. umount A and mount B can 
> > happen in parallel as the ordering does not matter.
> 
> Guangya Liu wrote:
> One question is if define `sequence` for each volume, then can we 
> guarantee that two different volumes can always keep the order?
> 
> e.g.
> Volume 1) driver: convoy, name: dvd1
> Volume 2) driver: flocker, name: dvd2
> 
> One container using the above two different volumes, can we guarantee 
> volume 1 mount point return first than volume 2 if letting differene sequence 
> manage those two volumes?
> 
> Jie Yu wrote:
> why does that matter?
> 
> Guangya Liu wrote:
> For such case:
> 
> Volume 1) driver: convoy, name: dvd1
> Volume 2) driver: flocker, name: dvd2
> 
> Volume 1 map to /tmp/abc1
> Volume 2 map to /tmp/abc2
> 
> If the return value of volume 1 and 2 mount point is not right, then 
> volume 1 mount point will mount to /tmp/abc1 and volume 2 will mount to 
> /tmp/abc2
> 
> I'm just not sure if using different volume sequence can guarantee the 
> order?

Correct a typo: If the return value of volume 1 and 2 mount point is not right, 
then volume 1 mount point will mount to `/tmp/abc2` and volume 2 will mount to 
`/tmp/abc1`


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130192
---


On 四月 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated 四月 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu 


> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109
> > 
> >
> > Please use a Sequence for each DockerVolume. umount A and mount B can 
> > happen in parallel as the ordering does not matter.
> 
> Guangya Liu wrote:
> One question is if define `sequence` for each volume, then can we 
> guarantee that two different volumes can always keep the order?
> 
> e.g.
> Volume 1) driver: convoy, name: dvd1
> Volume 2) driver: flocker, name: dvd2
> 
> One container using the above two different volumes, can we guarantee 
> volume 1 mount point return first than volume 2 if letting differene sequence 
> manage those two volumes?
> 
> Jie Yu wrote:
> why does that matter?

For such case:

Volume 1) driver: convoy, name: dvd1
Volume 2) driver: flocker, name: dvd2

Volume 1 map to /tmp/abc1
Volume 2 map to /tmp/abc2

If the return value of volume 1 and 2 mount point is not right, then volume 1 
mount point will mount to /tmp/abc1 and volume 2 will mount to /tmp/abc2

I'm just not sure if using different volume sequence can guarantee the order?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130192
---


On 四月 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated 四月 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Jie Yu 


> On April 22, 2016, 9:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109
> > 
> >
> > Please use a Sequence for each DockerVolume. umount A and mount B can 
> > happen in parallel as the ordering does not matter.
> 
> Guangya Liu wrote:
> One question is if define `sequence` for each volume, then can we 
> guarantee that two different volumes can always keep the order?
> 
> e.g.
> Volume 1) driver: convoy, name: dvd1
> Volume 2) driver: flocker, name: dvd2
> 
> One container using the above two different volumes, can we guarantee 
> volume 1 mount point return first than volume 2 if letting differene sequence 
> manage those two volumes?

why does that matter?


- Jie


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130192
---


On April 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu 


> On 四月 22, 2016, 9:49 p.m., Jie Yu wrote:
> > src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp, line 109
> > 
> >
> > Please use a Sequence for each DockerVolume. umount A and mount B can 
> > happen in parallel as the ordering does not matter.

One question is if define `sequence` for each volume, then can we guarantee 
that two different volumes can always keep the order?

e.g.
Volume 1) driver: convoy, name: dvd1
Volume 2) driver: flocker, name: dvd2

One container using the above two different volumes, can we guarantee volume 1 
mount point return first than volume 2 if letting differene sequence manage 
those two volumes?


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130192
---


On 四月 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated 四月 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Jie Yu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130192
---




src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp (line 109)


Please use a Sequence for each DockerVolume. umount A and mount B can 
happen in parallel as the ordering does not matter.



src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp (lines 129 - 
132)


I would reformat:
```
return sequences[...].add(
defer(PID<...>(this), [=]() {
  return _mount(driver, name, options);
}));
```


- Jie Yu


On April 22, 2016, 4:11 p.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 22, 2016, 4:11 p.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5013
> https://issues.apache.org/jira/browse/MESOS-5013
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/
---

(Updated 四月 22, 2016, 4:11 p.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Enabled Sequence mount for prepare().


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/44454/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/
---

(Updated 四月 22, 2016, 7:39 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Bugs: MESOS-5013
https://issues.apache.org/jira/browse/MESOS-5013


Repository: mesos


Description
---

Enabled Sequence mount for prepare().


Diffs
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/44454/diff/


Testing
---

make
make check


Thanks,

Guangya Liu

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread haosdent huang 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/#review130047
---


Ship it!




Ship It!

- haosdent huang


On April 22, 2016, 6:49 a.m., Guangya Liu wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44454/
> ---
> 
> (Updated April 22, 2016, 6:49 a.m.)
> 
> 
> Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
> Jie Yu.
> 
> 
> Bugs: MESOS-5104
> https://issues.apache.org/jira/browse/MESOS-5104
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Enabled Sequence mount for prepare().
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
> bedc687cc280d0b721fb84801039fd3614364cca 
>   src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
> 915e5ae755a55a02b7dfcda88165f27346cad955 
> 
> Diff: https://reviews.apache.org/r/44454/diff/
> 
> 
> Testing
> ---
> 
> make
> make check
> 
> 
> Thanks,
> 
> Guangya Liu
> 
>

Re: Review Request 44454: Enabled Sequence mount for prepare().

2016-04-22 Thread Guangya Liu 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44454/
---

(Updated 四月 22, 2016, 6:49 a.m.)


Review request for mesos, David vonThenen, Gilbert Song, haosdent huang, and 
Jie Yu.


Summary (updated)
-

Enabled Sequence mount for prepare().


Bugs: MESOS-5104
https://issues.apache.org/jira/browse/MESOS-5104


Repository: mesos


Description (updated)
---

Enabled Sequence mount for prepare().


Diffs (updated)
-

  src/slave/containerizer/mesos/isolators/docker/volume/isolator.hpp 
bedc687cc280d0b721fb84801039fd3614364cca 
  src/slave/containerizer/mesos/isolators/docker/volume/isolator.cpp 
915e5ae755a55a02b7dfcda88165f27346cad955 

Diff: https://reviews.apache.org/r/44454/diff/


Testing
---

make
make check


Thanks,

Guangya Liu