Re: Review Request 44475: Improve master slave metrics.

2016-03-09 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44475/#review122848
---



Patch looks great!

Reviews applied: [44473, 44474, 44475]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 9, 2016, 7:08 p.m., Cong Wang wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44475/
> ---
> 
> (Updated March 9, 2016, 7:08 p.m.)
> 
> 
> Review request for mesos, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan 
> Xu.
> 
> 
> Bugs: MESOS-4740
> https://issues.apache.org/jira/browse/MESOS-4740
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Improve master slave metrics.
> 
> 
> Diffs
> -
> 
>   src/master/master.hpp 4fa88f1968c92c1216c0af22a476ef7aa57ae961 
>   src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
>   src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
>   src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 
> 
> Diff: https://reviews.apache.org/r/44475/diff/
> 
> 
> Testing
> ---
> 
> Manual check
> 
> 
> Thanks,
> 
> Cong Wang
> 
>



Re: Review Request 44475: Improve master slave metrics.

2016-03-09 Thread Cong Wang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44475/
---

(Updated March 9, 2016, 7:08 p.m.)


Review request for mesos, Ben Mahler, Ian Downes, Vinod Kone, and Jiang Yan Xu.


Changes
---

Rebase


Summary (updated)
-

Improve master slave metrics.


Bugs: MESOS-4740
https://issues.apache.org/jira/browse/MESOS-4740


Repository: mesos


Description (updated)
---

Improve master slave metrics.


Diffs (updated)
-

  src/master/master.hpp 4fa88f1968c92c1216c0af22a476ef7aa57ae961 
  src/master/master.cpp 249e82ffcef35aa8df3c5b9faef5b9b25d68facc 
  src/master/metrics.hpp 9d201fcce1c46a890c86a889ab31029f9a061561 
  src/master/metrics.cpp 30c091198a8fdd6d6a957a351dc37d3dae7788e4 

Diff: https://reviews.apache.org/r/44475/diff/


Testing
---

Manual check


Thanks,

Cong Wang