Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 23, 2016, 9:38 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124996 --- Fix it, then Ship it! src/slave/slave.cpp (line 358)

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-23 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 23, 2016, 8:51 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-23 Thread Adam B
> On March 23, 2016, 12:30 a.m., Adam B wrote: > > src/slave/slave.cpp, lines 413-415 > > > > > > Who says custom authenticators can't use that flag? Make this a WARN > > instead Oh, because we don't pass

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-23 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124982 --- Fix it, then Ship it! Looks good. Just a couple

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-21 Thread Greg Mann
> On March 21, 2016, 9:55 a.m., Adam B wrote: > > Maybe all the http auth flag validation code should just go inside the > > `--authenticate_http` block, and you'll EXIT/WARN if they specify any > > related flags without enabling http authn. Since there is a default value for

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-21 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 21, 2016, 3:42 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-21 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124519 --- Maybe all the http auth flag validation code should just go

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-21 Thread Adam B
> On March 19, 2016, 3:03 a.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 373 > > > > > > Do we actually have to get the authenticator above if this flag is not > > set? > > Greg Mann wrote: > The code

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 10:03 a.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 373 > > > > > > Do we actually have to get the authenticator above if this flag is not > > set? > > Greg Mann wrote: > The

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 21, 2016, 4:50 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 21, 2016, 4:24 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 10:03 a.m., Joerg Schad wrote: > > src/slave/slave.cpp, line 373 > > > > > > Do we actually have to get the authenticator above if this flag is not > > set? The code directly above this line

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 20, 2016, 6:57 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 11:39 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > > > > > One part I don't like is that the same flag on the master has a > > different name credentials. > > I would

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
> On March 19, 2016, 9:16 a.m., Adam B wrote: > > src/tests/mesos.cpp, line 177 > > > > > > Why use `os::getcwd()` instead of `directory.get()` like "credential" > > and "fetch" above? Seems like

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-20 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 20, 2016, 5:27 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124157 --- Fix it, then Ship it! Only minor nits src/slave/flags.cpp

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124401 --- src/slave/flags.cpp (line 681)

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124392 --- src/slave/flags.cpp (line 685)

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review124387 --- Fix it, then Ship it! One last question src/tests/mesos.cpp

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 18, 2016, 6:32 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-19 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 17, 2016, 7:41 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-15 Thread Greg Mann
> On March 15, 2016, 10:33 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > > > > > As we are actively deprecated the old text based format with Mesos-228, > > does it make sense to only document the

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-15 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 15, 2016, 9:30 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-15 Thread Greg Mann
> On March 15, 2016, 10:33 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > > > > > As we are actively deprecated the old text based format with Mesos-228, > > does it make sense to only document the

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-15 Thread Joerg Schad
> On March 15, 2016, 10:33 a.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 682 > > > > > > As we are actively deprecated the old text based format with Mesos-228, > > does it make sense to only document the

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-15 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review123630 --- src/slave/flags.cpp (line 681)

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-13 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 14, 2016, 4:17 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-11 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 11, 2016, 9:48 a.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Alexander Rojas
> On March 10, 2016, 9:45 a.m., Adam B wrote: > > src/slave/flags.cpp, line 684 > > > > > > I wonder if/when we'll ever deprecate one of these formats. > > https://issues.apache.org/jira/browse/MESOS-2281 > >

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Alexander Rojas
> On March 10, 2016, 9:45 a.m., Adam B wrote: > > src/tests/mesos.cpp, lines 182-184 > > > > > > Any reason you can't reuse the previous `path` and `fd` variables? > > Greg Mann wrote: > We could do that;

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 10, 2016, 10:16 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Greg Mann
> On March 10, 2016, 3:55 p.m., Joerg Schad wrote: > > src/slave/flags.cpp, line 665 > > > > > > Did you add those flags to configuration.md or do you plan to do this > > via your script? Documentation is added in

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Joerg Schad
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review122929 --- src/slave/flags.cpp (line 665)

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 10, 2016, 3:52 p.m.) Review request for mesos, Adam B,

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Greg Mann
> On March 10, 2016, 8:45 a.m., Adam B wrote: > > src/slave/slave.cpp, line 372 > > > > > > So we only load the authenticators and even allow authentication if > > --authenticate_http is set? My understanding is

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-10 Thread Adam B
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review122892 --- Looks great! Just some minor nits and a question about

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 9, 2016, 8:47 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-09 Thread Greg Mann
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/ --- (Updated March 9, 2016, 8:42 p.m.) Review request for mesos, Adam B, Alexander

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-09 Thread Alexander Rojas
> On March 9, 2016, 4:56 a.m., Alexander Rojas wrote: > > src/slave/constants.cpp, line 58 > > > > > > Can you create a JIRA issue so we make the naming of the realm symetric > > in the master to _mesos-master_. I

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-09 Thread Greg Mann
> On March 9, 2016, 3:56 a.m., Alexander Rojas wrote: > > src/slave/constants.cpp, line 58 > > > > > > Can you create a JIRA issue so we make the naming of the realm symetric > > in the master to _mesos-master_. I

Re: Review Request 44515: Added agent flags for HTTP authentication.

2016-03-08 Thread Alexander Rojas
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44515/#review122668 --- Fix it, then Ship it! src/slave/constants.cpp (line 58)