Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-14 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review123478
---



The generated documentation is now wrong.  It almost loooks like no delegate 
was set on the master for some reason.

- Kevin Klues


On March 14, 2016, 5:40 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 14, 2016, 5:40 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 27b178efa1c2d1a00f557018e3343293ebfb3430 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp bda03da5d0fdc69b92fad2fad6662b805e49f046 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-14 Thread Neil Conway 


> On March 14, 2016, 6:54 p.m., Kevin Klues wrote:
> > The generated documentation is now wrong.  It almost loooks like no 
> > delegate was set on the master for some reason.

Ah -- I rebased but didn't actually rerun the script to pickup the recent 
changes; that is done now.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review123478
---


On March 14, 2016, 6:58 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 14, 2016, 6:58 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 27b178efa1c2d1a00f557018e3343293ebfb3430 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp bda03da5d0fdc69b92fad2fad6662b805e49f046 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-14 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/
---

(Updated March 14, 2016, 6:58 p.m.)


Review request for mesos and Adam B.


Changes
---

Reran script to pickup recent changes.


Repository: mesos


Description
---

Reran `generate-endpoint-help.py` script for `/weights` endpoint.


Diffs (updated)
-

  docs/endpoints/index.md 27b178efa1c2d1a00f557018e3343293ebfb3430 
  docs/endpoints/master/weights.md PRE-CREATION 
  src/master/http.cpp bda03da5d0fdc69b92fad2fad6662b805e49f046 

Diff: https://reviews.apache.org/r/44583/diff/


Testing
---

Previewed via site-docker.


Thanks,

Neil Conway

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-14 Thread Neil Conway 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/
---

(Updated March 14, 2016, 5:40 p.m.)


Review request for mesos and Adam B.


Changes
---

Rebase.


Repository: mesos


Description
---

Reran `generate-endpoint-help.py` script for `/weights` endpoint.


Diffs (updated)
-

  docs/endpoints/index.md 27b178efa1c2d1a00f557018e3343293ebfb3430 
  docs/endpoints/master/weights.md PRE-CREATION 
  src/master/http.cpp bda03da5d0fdc69b92fad2fad6662b805e49f046 

Diff: https://reviews.apache.org/r/44583/diff/


Testing
---

Previewed via site-docker.


Thanks,

Neil Conway

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-14 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review123365
---


Ship it!




Ship It!

- Joerg Schad


On March 9, 2016, 6:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 9, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md bd70819b186c33718f66830034979d415767a2a3 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-13 Thread Kevin Klues 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review123341
---


Ship it!




Ship It!

- Kevin Klues


On March 9, 2016, 6:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 9, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md bd70819b186c33718f66830034979d415767a2a3 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-13 Thread Adam B 


> On March 13, 2016, 4:31 a.m., Adam B wrote:
> > Ship It!

Sorry, needs a rebase after https://reviews.apache.org/r/44693/


- Adam


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review123311
---


On March 9, 2016, 10:04 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 9, 2016, 10:04 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md bd70819b186c33718f66830034979d415767a2a3 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-13 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review123311
---


Ship it!




Ship It!

- Adam B


On March 9, 2016, 10:04 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 9, 2016, 10:04 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md bd70819b186c33718f66830034979d415767a2a3 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-10 Thread Neil Conway 


> On March 10, 2016, 7:16 a.m., Adam B wrote:
> > src/master/http.cpp, lines 1166-1167
> > 
> >
> > Why is the space removed here?
> > Do we need to put a space after `JSON` instead?

TLDR processing inserts newlines automatically between strings; a space is not 
required after 'JSON', and isn't useful before 'and'. For reference, see how 
the other TLDR strings work.


- Neil


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review122889
---


On March 9, 2016, 6:04 p.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 9, 2016, 6:04 p.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md bd70819b186c33718f66830034979d415767a2a3 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>

Re: Review Request 44583: Reran `generate-endpoint-help.py` script for `/weights` endpoint.

2016-03-09 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44583/#review122889
---




src/master/http.cpp (lines 1166 - 1167)


Why is the space removed here?
Do we need to put a space after `JSON` instead?


- Adam B


On March 9, 2016, 10:04 a.m., Neil Conway wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44583/
> ---
> 
> (Updated March 9, 2016, 10:04 a.m.)
> 
> 
> Review request for mesos and Adam B.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran `generate-endpoint-help.py` script for `/weights` endpoint.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md bd70819b186c33718f66830034979d415767a2a3 
>   docs/endpoints/master/weights.md PRE-CREATION 
>   src/master/http.cpp 7304bfd5350d763d9ed1d5acdc285874b6d8f5df 
> 
> Diff: https://reviews.apache.org/r/44583/diff/
> 
> 
> Testing
> ---
> 
> Previewed via site-docker.
> 
> 
> Thanks,
> 
> Neil Conway
> 
>