Re: Review Request 44620: Documented how to make executors work with SSL.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review123308
---



Patch looks great!

Reviews applied: [44620]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 7:11 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 7:11 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review123305
---


Ship it!




Looks good, but I'll clean it up a bit before committing, if you don't mind:

Executors must be able to access the SSL environment variables and the files 
referred to by those variables. Environment variables can be provided to an 
executor by specifying `CommandInfo.environment` or by using the slave's 
`--executor_environment_variables` command line flag. If the slave and the 
executor are running in separate containers, `ContainerInfo.volumes` can be 
used to mount SSL files from the host into the executor's container.

- Adam B


On March 11, 2016, 11:11 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 11:11 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/
---

(Updated March 11, 2016, 8:11 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Addressed issues.


Bugs: MESOS-4750
https://issues.apache.org/jira/browse/MESOS-4750


Repository: mesos


Description
---

Documented how to make executors work with SSL.


Diffs (updated)
-

  docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 

Diff: https://reviews.apache.org/r/44620/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 44620: Documented how to make executors work with SSL.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review123184
---


Fix it, then Ship it!




Verified the paragraph shows up correctly via `support/site-docker/...`.


docs/ssl.md (line 101)


Tiny nit on the last sentence:

s/the executors container./the executor's container./


- Joseph Wu


On March 11, 2016, 7:21 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 7:21 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/
---

(Updated March 11, 2016, 4:21 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Addressed Alexander's comments.


Bugs: MESOS-4750
https://issues.apache.org/jira/browse/MESOS-4750


Repository: mesos


Description
---

Documented how to make executors work with SSL.


Diffs (updated)
-

  docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 

Diff: https://reviews.apache.org/r/44620/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 44620: Documented how to make executors work with SSL.

[Alexander Rojas]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review123136
---




docs/ssl.md (line 101)


_You need to make sure… …and the files these variables are refering to…_

Remove _…to the respective values…_ (ask a native speaker about this one).

Change to: _…of the slave's command line f lags…_(Ask Bernd for the correct 
word here)

Don't mix _slave_ and _agents_.


- Alexander Rojas


On March 11, 2016, 12:26 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review123130
---



Patch looks great!

Reviews applied: [44620]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 11:26 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 11:26 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Jan Schlicht]

> On March 10, 2016, 10:32 p.m., Joseph Wu wrote:
> > docs/ssl.md, line 102
> > 
> >
> > Not sure exactly how much detail we want to add here about specific 
> > configurations (especially considering the upcoming change to the 
> > containerizer's environment variables).  But here's some more specifics:
> > 
> > * When using the DockerContainerizer + normal Mesos agent, the docker 
> > executor shares the same root as the agent.  So as long as the environment 
> > variables are passed on (via the methods you listed), this will work.
> > * When using the DockerContainerizer + dockerized Mesos agent, you will 
> > need to add an additional `ContainerInfo.volumes` which mounts from the 
> > host (*not the agent*) to the executor.  In this case, the task will have 
> > access to the keys/certs :(
> > * The UnifiedContainerizer + normal Mesos agent case will probably be 
> > similar to the DockerContainerizer + normal Mesos agent case (I haven't 
> > tried this).
> > * UnifiedContainerizer + Mesos launched via UnifiedContainerizer ???

Thanks for mentioning the need for volumes for dockerized executors!
I've updated the documentation without going too much into detail and 
mentioning a more general "containerized" environment. I hope that this is 
enough information, not too less.


- Jan


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review122997
---


On March 11, 2016, 12:26 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 11, 2016, 12:26 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Documented how to make executors work with SSL.
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Jan Schlicht]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/
---

(Updated March 11, 2016, 12:26 p.m.)


Review request for mesos, Adam B and Alexander Rojas.


Changes
---

Mention volumes to mount SSL files in dockerized environments.


Bugs: MESOS-4750
https://issues.apache.org/jira/browse/MESOS-4750


Repository: mesos


Description (updated)
---

Documented how to make executors work with SSL.


Diffs (updated)
-

  docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 

Diff: https://reviews.apache.org/r/44620/diff/


Testing
---

make check


Thanks,

Jan Schlicht

Re: Review Request 44620: Documented how to make executors work with SSL.

[Joseph Wu]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review122997
---




docs/ssl.md (line 102)


Not sure exactly how much detail we want to add here about specific 
configurations (especially considering the upcoming change to the 
containerizer's environment variables).  But here's some more specifics:

* When using the DockerContainerizer + normal Mesos agent, the docker 
executor shares the same root as the agent.  So as long as the environment 
variables are passed on (via the methods you listed), this will work.
* When using the DockerContainerizer + dockerized Mesos agent, you will 
need to add an additional `ContainerInfo.volumes` which mounts from the host 
(*not the agent*) to the executor.  In this case, the task will have access to 
the keys/certs :(
* The UnifiedContainerizer + normal Mesos agent case will probably be 
similar to the DockerContainerizer + normal Mesos agent case (I haven't tried 
this).
* UnifiedContainerizer + Mesos launched via UnifiedContainerizer ???


- Joseph Wu


On March 10, 2016, 5:46 a.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 10, 2016, 5:46 a.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>

Re: Review Request 44620: Documented how to make executors work with SSL.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44620/#review122928
---



Patch looks great!

Reviews applied: [44620]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 10, 2016, 1:46 p.m., Jan Schlicht wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44620/
> ---
> 
> (Updated March 10, 2016, 1:46 p.m.)
> 
> 
> Review request for mesos, Adam B and Alexander Rojas.
> 
> 
> Bugs: MESOS-4750
> https://issues.apache.org/jira/browse/MESOS-4750
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> see summary
> 
> 
> Diffs
> -
> 
>   docs/ssl.md 3de2a3e931091e002dc4b259c70eadd89a52b059 
> 
> Diff: https://reviews.apache.org/r/44620/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> 
> Thanks,
> 
> Jan Schlicht
> 
>