Re: Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44630/#review123574 --- Ship it! Would be great to include some description in these reviews, for example: `EXECUTOR_SHUTDOWN_GRACE_PERIOD` is now a flag default and is no longer intended to be used as a hard-coded constant used in the source. The general pattern in the code is to name a flag default as `DEFAULT_X` rather than just `X`. - Ben Mahler On March 14, 2016, 5:44 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44630/ > --- > > (Updated March 14, 2016, 5:44 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-1571 > https://issues.apache.org/jira/browse/MESOS-1571 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e > src/slave/constants.hpp 4110061d576d5e20e512e84bb049b6ac910ceab0 > src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd > > Diff: https://reviews.apache.org/r/44630/diff/ > > > Testing > --- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44630/ --- (Updated March 14, 2016, 5:44 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1571 https://issues.apache.org/jira/browse/MESOS-1571 Repository: mesos Description --- See summary. Diffs (updated) - src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e src/slave/constants.hpp 4110061d576d5e20e512e84bb049b6ac910ceab0 src/slave/flags.cpp 5bacf109bcd9c9eae1b7ec3c32095c72899ebdbd Diff: https://reviews.apache.org/r/44630/diff/ Testing --- The complete chain was tested. See https://reviews.apache.org/r/44662/. Thanks, Alexander Rukletsov
Re: Review Request 44630: Renamed `EXECUTOR_SHUTDOWN_GRACE_PERIOD` constant.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44630/ --- (Updated March 11, 2016, 4 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-1571 https://issues.apache.org/jira/browse/MESOS-1571 Repository: mesos Description --- See summary. Diffs (updated) - src/exec/exec.cpp dec7e8814e7151718d1c89381458753f2e22739e src/slave/constants.hpp bcbb1401aa8f9f04c4f9256bb4f560e18d8994e0 src/slave/constants.cpp 0f0d8e4b079d136d250f83cfc768de8c98b8bee2 src/slave/flags.cpp eb470154f30634b3db439be1c122ff93d3147afe Diff: https://reviews.apache.org/r/44630/diff/ Testing --- The complete chain was tested. See https://reviews.apache.org/r/44662/. Thanks, Alexander Rukletsov
