Re: Review Request 44672: Added normalize method to registry puller.

2016-03-22 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review124818
---


Ship it!




Ship It!

- Jie Yu


On March 21, 2016, 7:06 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 21, 2016, 7:06 p.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, Shuai Lin, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-4877
> https://issues.apache.org/jira/browse/MESOS-4877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/
---

(Updated March 21, 2016, 12:06 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, Shuai Lin, 
and Timothy Chen.


Bugs: MESOS-4877
https://issues.apache.org/jira/browse/MESOS-4877


Repository: mesos


Description
---

Added normalize method to registry puller.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6d637ed14f35feb554c8fcc63a7a7e046aaca574 

Diff: https://reviews.apache.org/r/44672/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh --gtest_filter="*ProvisionerDockerRegistryPullerTest*"


Thanks,

Gilbert Song



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review124567
---




src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 171)


What if `reference.has_registry() == true`?

For instance, a user can specify:
`index.docker.io/busybox`


- Jie Yu


On March 21, 2016, 6:44 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 21, 2016, 6:44 a.m.)
> 
> 
> Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, Shuai Lin, 
> and Timothy Chen.
> 
> 
> Bugs: MESOS-4877
> https://issues.apache.org/jira/browse/MESOS-4877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/
---

(Updated March 20, 2016, 11:44 p.m.)


Review request for mesos, Guangya Liu, Artem Harutyunyan, Jie Yu, Shuai Lin, 
and Timothy Chen.


Bugs: MESOS-4877
https://issues.apache.org/jira/browse/MESOS-4877


Repository: mesos


Description
---

Added normalize method to registry puller.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6d637ed14f35feb554c8fcc63a7a7e046aaca574 

Diff: https://reviews.apache.org/r/44672/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh --gtest_filter="*ProvisionerDockerRegistryPullerTest*"


Thanks,

Gilbert Song



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Gilbert Song


> On March 19, 2016, 10:45 a.m., Jie Yu wrote:
> > Please add a test to test if we can properly handle images like 'alpine' 
> > directly without the 'library/' prefix.

Test was in patch #44673.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review123690
---


On March 14, 2016, 10:32 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 14, 2016, 10:32 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4877
> https://issues.apache.org/jira/browse/MESOS-4877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-21 Thread Gilbert Song


> On March 18, 2016, 11:54 p.m., Shuai Lin wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line 
> > 182
> > 
> >
> > I would suggest to add a new test for the `normalize` function.
> 
> Guangya Liu wrote:
> I think that the test was already covered in the followint patch here 
> https://reviews.apache.org/r/44673/

Thanks, Guangya. Test was in patch #44673.


- Gilbert


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review124379
---


On March 14, 2016, 10:32 a.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 14, 2016, 10:32 a.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4877
> https://issues.apache.org/jira/browse/MESOS-4877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-19 Thread Guangya Liu


> On 三月 19, 2016, 6:54 a.m., Shuai Lin wrote:
> > src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp, line 
> > 182
> > 
> >
> > I would suggest to add a new test for the `normalize` function.

I think that the test was already covered in the followint patch here 
https://reviews.apache.org/r/44673/


- Guangya


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review124379
---


On 三月 14, 2016, 5:32 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated 三月 14, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4877
> https://issues.apache.org/jira/browse/MESOS-4877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-19 Thread Jie Yu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review123690
---



Please add a test to test if we can properly handle images like 'alpine' 
directly without the 'library/' prefix.


src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 175)


`path::join("library", _reference.repository());


- Jie Yu


On March 14, 2016, 5:32 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 14, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4877
> https://issues.apache.org/jira/browse/MESOS-4877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-19 Thread Shuai Lin

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review124379
---




src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 182)


I would suggest to add a new test for the `normalize` function.


- Shuai Lin


On March 14, 2016, 5:32 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 14, 2016, 5:32 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Bugs: MESOS-4877
> https://issues.apache.org/jira/browse/MESOS-4877
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-14 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/
---

(Updated March 14, 2016, 5:32 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Bugs: MESOS-4877
https://issues.apache.org/jira/browse/MESOS-4877


Repository: mesos


Description
---

Added normalize method to registry puller.


Diffs
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6d637ed14f35feb554c8fcc63a7a7e046aaca574 

Diff: https://reviews.apache.org/r/44672/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh --gtest_filter="*ProvisionerDockerRegistryPullerTest*"


Thanks,

Gilbert Song



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-13 Thread Guangya Liu

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review123307
---



Can you please link https://issues.apache.org/jira/browse/MESOS-4877 to this RR?

- Guangya Liu


On 三月 10, 2016, 11:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated 三月 10, 2016, 11:49 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-12 Thread haosdent huang

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review123295
---


Ship it!




Ship It!

- haosdent huang


On March 10, 2016, 11:49 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 10, 2016, 11:49 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-10 Thread Gilbert Song

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/
---

(Updated March 10, 2016, 3:49 p.m.)


Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.


Repository: mesos


Description (updated)
---

Added normalize method to registry puller.


Diffs (updated)
-

  src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
6d637ed14f35feb554c8fcc63a7a7e046aaca574 

Diff: https://reviews.apache.org/r/44672/diff/


Testing
---

make check

sudo ./bin/mesos-test.sh --gtest_filter="*ProvisionerDockerRegistryPullerTest*"


Thanks,

Gilbert Song



Re: Review Request 44672: Added normalize method to registry puller.

2016-03-10 Thread Timothy Chen

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44672/#review123019
---




src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp (line 173)


From the docker code base they're checking against docker.io, not 
regsitry-1.docker.io, as I assume registry-1 is not a permanent name.
I would suggest we don't hard code that as well.


- Timothy Chen


On March 10, 2016, 8:05 p.m., Gilbert Song wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44672/
> ---
> 
> (Updated March 10, 2016, 8:05 p.m.)
> 
> 
> Review request for mesos, Artem Harutyunyan, Jie Yu, and Timothy Chen.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Added normalize method to registry puller.
> 
> Logic is verified with docker go code 
> (https://github.com/docker/docker/blob/v1.10.2/reference/reference.go#L171~#L173).
> 
> 
> Diffs
> -
> 
>   src/slave/containerizer/mesos/provisioner/docker/registry_puller.cpp 
> 6d637ed14f35feb554c8fcc63a7a7e046aaca574 
> 
> Diff: https://reviews.apache.org/r/44672/diff/
> 
> 
> Testing
> ---
> 
> make check
> 
> sudo ./bin/mesos-test.sh 
> --gtest_filter="*ProvisionerDockerRegistryPullerTest*"
> 
> 
> Thanks,
> 
> Gilbert Song
> 
>