Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 24, 2016, 4:15 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-4909 https://issues.apache.org/jira/browse/MESOS-4909 Repository: mesos Description --- See summary. Diffs (updated) - src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca src/tests/master_validation_tests.cpp 8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d Diff: https://reviews.apache.org/r/44707/diff/ Testing --- On Mac OS 10.10.4: `make check` `GTEST_FILTER="TaskValidationTest.KillPolicyGracePeriodIsNonNegative" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov
Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 23, 2016, 11:24 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-4909 https://issues.apache.org/jira/browse/MESOS-4909 Repository: mesos Description --- See summary. Diffs (updated) - src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca src/tests/master_validation_tests.cpp 8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d Diff: https://reviews.apache.org/r/44707/diff/ Testing --- On Mac OS 10.10.4: `make check` `GTEST_FILTER="TaskValidationTest.KillPolicyGracePeriodIsNonNegative" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov
Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 22, 2016, 5:10 p.m.) Review request for mesos and Ben Mahler. Changes --- Added a test. Bugs: MESOS-4909 https://issues.apache.org/jira/browse/MESOS-4909 Repository: mesos Description --- See summary. Diffs (updated) - src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca src/tests/master_validation_tests.cpp 8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d Diff: https://reviews.apache.org/r/44707/diff/ Testing --- On Mac OS 10.10.4: `make check` `GTEST_FILTER="TaskValidationTest.KillPolicyGracePeriodIsNonNegative" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov
Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 22, 2016, 10:06 a.m.) Review request for mesos and Ben Mahler. Changes --- Updated testing section. Bugs: MESOS-4909 https://issues.apache.org/jira/browse/MESOS-4909 Repository: mesos Description --- See summary. Diffs - src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca Diff: https://reviews.apache.org/r/44707/diff/ Testing (updated) --- On Mac OS 10.10.4: `make check` `GTEST_FILTER="TaskValidationTest.KillPolicyGracePeriodIsNonNegative" ./bin/mesos-tests.sh --gtest_repeat=100 --gtest_break_on_failure` Thanks, Alexander Rukletsov
Re: Review Request 44707: Added validation for task's kill policy.
> On March 15, 2016, 8:35 p.m., Ben Mahler wrote: > > Could you add a corresponding test? Having it in the header should make > > this really easy :) Sure, but I'll write a more complex test than just unit testing the validation function. - Alexander --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/#review123743 --- On March 15, 2016, 3:47 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44707/ > --- > > (Updated March 15, 2016, 3:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4909 > https://issues.apache.org/jira/browse/MESOS-4909 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > > Diff: https://reviews.apache.org/r/44707/diff/ > > > Testing > --- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/#review124341 --- Ship it! Please pull out the validation test into a simple unit test within master_validation_tests.cpp. - Ben Mahler On March 15, 2016, 3:47 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44707/ > --- > > (Updated March 15, 2016, 3:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4909 > https://issues.apache.org/jira/browse/MESOS-4909 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > > Diff: https://reviews.apache.org/r/44707/diff/ > > > Testing > --- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 44707: Added validation for task's kill policy.
> On March 15, 2016, 8:35 p.m., Ben Mahler wrote: > > Could you add a corresponding test? Having it in the header should make > > this really easy :) > > Alexander Rukletsov wrote: > Sure, but I'll write a more complex test than just unit testing the > validation function. Per the suggestion from the ExecutorInfo change, how about we pull up the simple unit test for this within master_validation_tests.cpp to be consistent? - Ben --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/#review123743 --- On March 15, 2016, 3:47 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44707/ > --- > > (Updated March 15, 2016, 3:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4909 > https://issues.apache.org/jira/browse/MESOS-4909 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > > Diff: https://reviews.apache.org/r/44707/diff/ > > > Testing > --- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/#review123743 --- Could you add a corresponding test? Having it in the header should make this really easy :) - Ben Mahler On March 15, 2016, 3:47 p.m., Alexander Rukletsov wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44707/ > --- > > (Updated March 15, 2016, 3:47 p.m.) > > > Review request for mesos and Ben Mahler. > > > Bugs: MESOS-4909 > https://issues.apache.org/jira/browse/MESOS-4909 > > > Repository: mesos > > > Description > --- > > See summary. > > > Diffs > - > > src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b > src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca > > Diff: https://reviews.apache.org/r/44707/diff/ > > > Testing > --- > > The complete chain was tested. See https://reviews.apache.org/r/44662/. > > > Thanks, > > Alexander Rukletsov > >
Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 15, 2016, 3:47 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-4909 https://issues.apache.org/jira/browse/MESOS-4909 Repository: mesos Description --- See summary. Diffs (updated) - src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca Diff: https://reviews.apache.org/r/44707/diff/ Testing --- The complete chain was tested. See https://reviews.apache.org/r/44662/. Thanks, Alexander Rukletsov
Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 15, 2016, 2:28 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-4909 https://issues.apache.org/jira/browse/MESOS-4909 Repository: mesos Description --- See summary. Diffs (updated) - src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca Diff: https://reviews.apache.org/r/44707/diff/ Testing --- The complete chain was tested. See https://reviews.apache.org/r/44662/. Thanks, Alexander Rukletsov
Re: Review Request 44707: Added validation for task's kill policy.
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44707/ --- (Updated March 14, 2016, 5:49 p.m.) Review request for mesos and Ben Mahler. Bugs: MESOS-4909 https://issues.apache.org/jira/browse/MESOS-4909 Repository: mesos Description --- See summary. Diffs (updated) - src/master/validation.hpp 29dbdf1da540db4966ff9e86037badde06e69a4b src/master/validation.cpp 820a9faee6fde09a98317854b181fe897167e2ca Diff: https://reviews.apache.org/r/44707/diff/ Testing --- The complete chain was tested. See https://reviews.apache.org/r/44662/. Thanks, Alexander Rukletsov
