Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44711/#review123372
---


Ship it!




Ship It!

- Adam B


On March 13, 2016, 11:54 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44711/
> ---
> 
> (Updated March 13, 2016, 11:54 a.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Bugs: MESOS-4844
> https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reflected default authentication of endpoints in documentation.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
> 
> Diff: https://reviews.apache.org/r/44711/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44711/#review123324
---



Patch looks great!

Reviews applied: [44286, 44186, 44621, 44711]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 13, 2016, 6:54 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44711/
> ---
> 
> (Updated March 13, 2016, 6:54 p.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Bugs: MESOS-4844
> https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reflected default authentication of endpoints in documentation.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
> 
> Diff: https://reviews.apache.org/r/44711/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

[Joerg Schad]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44711/
---

(Updated March 13, 2016, 6:54 p.m.)


Review request for mesos, Adam B and Greg Mann.


Changes
---

Addressed review.


Bugs: MESOS-4844
https://issues.apache.org/jira/browse/MESOS-4844


Repository: mesos


Description
---

Reflected default authentication of endpoints in documentation.


Diffs (updated)
-

  docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 

Diff: https://reviews.apache.org/r/44711/diff/


Testing
---


Thanks,

Joerg Schad

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

[Adam B]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44711/#review123304
---



Slow down, partner. Even after Greg's patch to add authn to basic agent HTTP 
endpoints, there are still a lot of unauthenticated endpoints.


docs/authentication.md (line 12)


I wouldn't call it "most" yet. Maybe "many". By my count, we're still 
excluding all the agent endpoints, plus:
/registrar(id)/registry
/files/*
/logging
/metrics/snapshot 
/profiler/*
/system/stats.json
/help/*

Can we also update the HTTP endpoint help to specify that authentication is 
required for endpoints when it is? (Maybe even base the answer on the actual 
--authenticate_http value)


- Adam B


On March 11, 2016, 8:48 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44711/
> ---
> 
> (Updated March 11, 2016, 8:48 a.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Bugs: MESOS-4844
> https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reflected default authentication of endpoints in documentation.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
> 
> Diff: https://reviews.apache.org/r/44711/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

[Mesos ReviewBot]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44711/#review123194
---



Patch looks great!

Reviews applied: [44286, 44186, 44621, 44711]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 11, 2016, 4:48 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44711/
> ---
> 
> (Updated March 11, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Bugs: MESOS-4844
> https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reflected default authentication of endpoints in documentation.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
> 
> Diff: https://reviews.apache.org/r/44711/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 44711: Updated authentication.md after most endpoints enable authentication.

[Greg Mann]

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44711/#review123168
---


Ship it!




Ship It!

- Greg Mann


On March 11, 2016, 4:48 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44711/
> ---
> 
> (Updated March 11, 2016, 4:48 p.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Bugs: MESOS-4844
> https://issues.apache.org/jira/browse/MESOS-4844
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reflected default authentication of endpoints in documentation.
> 
> 
> Diffs
> -
> 
>   docs/authentication.md dd538b512c6f822cd742fc6e2f3d4f7fbffadc06 
> 
> Diff: https://reviews.apache.org/r/44711/diff/
> 
> 
> Testing
> ---
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>