Re: Review Request 44768: Included weights endpoint in endpoint documentation.

2016-03-13 Thread Neil Conway

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44768/#review123340
---



I already have a patch out for this -- https://reviews.apache.org/r/44583/

- Neil Conway


On March 13, 2016, 9:37 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44768/
> ---
> 
> (Updated March 13, 2016, 9:37 p.m.)
> 
> 
> Review request for mesos, Adam B, Kevin Klues, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Even though the weights endpoint had been added with a corresponding HELP(), 
> the documentation had not been regenerated.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 27b178efa1c2d1a00f557018e3343293ebfb3430 
>   docs/endpoints/master/weights.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44768/diff/
> 
> 
> Testing
> ---
> 
> Viewed generated docs.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 44768: Included weights endpoint in endpoint documentation.

2016-03-13 Thread Mesos ReviewBot

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44768/#review123335
---



Patch looks great!

Reviews applied: [44768]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' 
COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On March 13, 2016, 9:37 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44768/
> ---
> 
> (Updated March 13, 2016, 9:37 p.m.)
> 
> 
> Review request for mesos, Adam B, Kevin Klues, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Even though the weights endpoint had been added with a corresponding HELP(), 
> the documentation had not been regenerated.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 27b178efa1c2d1a00f557018e3343293ebfb3430 
>   docs/endpoints/master/weights.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44768/diff/
> 
> 
> Testing
> ---
> 
> Viewed generated docs.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>



Re: Review Request 44768: Included weights endpoint in endpoint documentation.

2016-03-13 Thread Kevin Klues

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44768/#review123332
---


Ship it!




Ship It!

- Kevin Klues


On March 13, 2016, 9:37 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/44768/
> ---
> 
> (Updated March 13, 2016, 9:37 p.m.)
> 
> 
> Review request for mesos, Adam B, Kevin Klues, and Neil Conway.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Even though the weights endpoint had been added with a corresponding HELP(), 
> the documentation had not been regenerated.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/index.md 27b178efa1c2d1a00f557018e3343293ebfb3430 
>   docs/endpoints/master/weights.md PRE-CREATION 
> 
> Diff: https://reviews.apache.org/r/44768/diff/
> 
> 
> Testing
> ---
> 
> Viewed generated docs.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>