Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 24, 2016, 4:14 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44854: Added validation for executor's shutdown grace period.

> On March 23, 2016, 6:49 p.m., Ben Mahler wrote: > > src/tests/master_validation_tests.cpp, lines 1175-1176 > > > > > > Why the explicit detector? After recent test harness refactoring, there is no `StartSlave()`

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/#review125090 --- Fix it, then Ship it! Thanks for moving the test!

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 22, 2016, 10:05 a.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 21, 2016, 6:38 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 21, 2016, 2:28 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/ --- (Updated March 17, 2016, 11:34 p.m.) Review request for mesos and Ben Mahler.

Re: Review Request 44854: Added validation for executor's shutdown grace period.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44854/#review124290 --- Ship it! The change looks good but please add a test for this.

Re: Review Request 44854: Added validation for executor's shutdown grace period.

> On March 18, 2016, 9:33 p.m., Ben Mahler wrote: > > The change looks good but please add a test for this. > > > > Ideally there could be a stateless validateExecutorInfo, in addition to the > > one that needs the master state. In the absence of this, you can write a > > test that spins up a

Re: Review Request 44854: Added validation for executor's shutdown grace period.

> On March 18, 2016, 9:33 p.m., Ben Mahler wrote: > > The change looks good but please add a test for this. > > > > Ideally there could be a stateless validateExecutorInfo, in addition to the > > one that needs the master state. In the absence of this, you can write a > > test that spins up a