-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/44881/
-----------------------------------------------------------
(Updated 三月 16, 2016, 2:07 a.m.)
Review request for mesos.
Changes
-------
Make the summary more informative
Summary (updated)
-----------------
Generize perf event parsing to match PerfStatistics filed name for "perf stat"
Bugs: MESOS-4955
https://issues.apache.org/jira/browse/MESOS-4955
Repository: mesos
Description
-------
Current design does not support event like:
SUBSYS/EVENT <- Most notable intel_cqm/llc_occupancy/
SUSSYS:EVENT <- All Tracepoint event
The current logic could be easily expended a bit to support
above to scenario.
Diffs
-----
include/mesos/mesos.proto 3d22ec32655dca741169e1f0e382303e061c38b7
include/mesos/v1/mesos.proto 31960a52061f70d80528fb8326522ae1d6f75b2c
src/linux/perf.cpp 1c113a2b3f57877e132bbd65e01fb2f045132128
Diff: https://reviews.apache.org/r/44881/diff/
Testing
-------
Before this modification, slave spew:
E0316 09:37:15.352880 116764 perf_event.cpp:408] Failed to get perf sample:
Failed to parse perf sample: Unexpected event 'intel_cqm/llc_occupancy/' in
perf output at line:
0.00,Bytes,intel_cqm/llc_occupancy/,mesos/fad99e5c-5ef2-4908-83de-3b5d7c2bb71f,9795836,100.00
After this modificaiton, I could intel_cqm/llc_occupancy statistics.
Thanks,
fan du
