Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/#review123971 --- Ship it! Ship It! - Jie Yu On March 17, 2016, 1:52 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44883/ > --- > > (Updated March 17, 2016, 1:52 a.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-4954 > https://issues.apache.org/jira/browse/MESOS-4954 > > > Repository: mesos > > > Description > --- > > This fix changes the URL fetcher error message from LOG(ERROR) > to LOG(INFO) as the plugin is actually skipped if it is not > created. > > > Diffs > - > > src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 > > Diff: https://reviews.apache.org/r/44883/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).
> On March 16, 2016, 7:57 p.m., Anand Mazumdar wrote: > > LGTM. Thanks for putting out a patch for this. > > > > Can you also add Jie as a reviewer and as a shepherd to the JIRA? Thanks a lot Anand! Just updated the review request and also added Jie as the reviewer. Let me know if there is anything else I need to do. - Yong --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/#review123830 --- On March 17, 2016, 1:52 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44883/ > --- > > (Updated March 17, 2016, 1:52 a.m.) > > > Review request for mesos, Anand Mazumdar and Jie Yu. > > > Bugs: MESOS-4954 > https://issues.apache.org/jira/browse/MESOS-4954 > > > Repository: mesos > > > Description > --- > > This fix changes the URL fetcher error message from LOG(ERROR) > to LOG(INFO) as the plugin is actually skipped if it is not > created. > > > Diffs > - > > src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 > > Diff: https://reviews.apache.org/r/44883/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/ --- (Updated March 17, 2016, 1:47 a.m.) Review request for mesos, Anand Mazumdar and Jie Yu. Changes --- Update review request and add Jie to the reviewer based on suggestions from Anand. Bugs: MESOS-4954 https://issues.apache.org/jira/browse/MESOS-4954 Repository: mesos Description --- This fix changes the URL fetcher error message from LOG(ERROR) to LOG(INFO) as the plugin is actually skipped if it is not created. Diffs (updated) - docs/endpoints/index.md 4fc5583e27dda6df6dfc9f3cee72925a07cdd2b3 docs/endpoints/master/weights.md 632be242d85fbd61ded62d846e385009a321533c src/master/http.cpp b47ab7cc86c0a56a81815a98bd63f37a1175ba7f src/tests/authentication_tests.cpp 8143cd7a22bbdbcd0fc613cb44eae8b55fd458e7 src/tests/cluster.hpp 06424dd741aed2261a926429bb0fc7dea141c11b src/tests/cluster.cpp 22167da70a855a39fd9c3ca980304372c70bd8d3 src/tests/command_executor_tests.cpp 970cdc39f4f2b0377d36acf2465d377d2a6e1d05 src/tests/container_logger_tests.cpp 71101c31cee6a400b89cf285cf0a105d2d1534a8 src/tests/containerizer/docker_containerizer_tests.cpp f6fce7df82417e029fadf805d6e0b793f396aa69 src/tests/containerizer/external_containerizer_test.cpp 5e2116355418f5a0716cfd1573bab48ba75df596 src/tests/containerizer/filesystem_isolator_tests.cpp b3bd5a03266150a0cd83c966d646a32c419bf512 src/tests/containerizer/isolator_tests.cpp 6a2e25b967742c034364d19372f06aa9f9cdf828 src/tests/containerizer/memory_pressure_tests.cpp be6c3a118b528c39c534da423c15e9dcbb970dbc src/tests/containerizer/mesos_containerizer_tests.cpp e849932ab558ccd792080433169ae50dc208a12e src/tests/containerizer/port_mapping_tests.cpp d89780f0c62e27f18b08fbd99bc25ac62d0f5f3c src/tests/containerizer/provisioner_docker_tests.cpp 72d4c3e8756e1bea2332db20654af0a5fbb124f1 src/tests/containerizer/runtime_isolator_tests.cpp 9f3b0b08da7cebba722062a9932fae1b5f825efb src/tests/credentials_tests.cpp b61ba2ea5df8957f12659de219f6a57cf30d987a src/tests/disk_quota_tests.cpp 7f5e32f3239db3adf6e4cec2df15ccf89b4f13f4 src/tests/dynamic_weights_tests.cpp ee0c4b1cc20e76a35a8e4e445f6827a1fc33e6c6 src/tests/exception_tests.cpp a50ccf1255dee59fdbc6fb1539bd1f6429458fb4 src/tests/executor_http_api_tests.cpp ff7b672e03185fca8b408b8805223a314fa3e483 src/tests/fault_tolerance_tests.cpp f99413f56e96a796d3d45decad1f049e6a238789 src/tests/fetcher_cache_tests.cpp 645dae208cb2b0aa2d2181d96eb1fd8893975430 src/tests/gc_tests.cpp 42059b2d6544f360cdc9230fe6ed33a11a15bc50 src/tests/health_check_tests.cpp d32164aeb1eb439bd062afa28614dd919e24f06b src/tests/hook_tests.cpp 595991deab38c34e918601e85d250dc995d0f34c src/tests/http_fault_tolerance_tests.cpp c06e07daf6d6519c10489310cd4275ae94f302c6 src/tests/master_allocator_tests.cpp b41ba2bda4d680f6fc42f525719973d56c11fe31 src/tests/master_authorization_tests.cpp 8b9b8991fbb8c5a5beb69416a9c4a4ef3525942d src/tests/master_contender_detector_tests.cpp bbce379e5a0a0ca608579d0ab2b10970e9cd5ef1 src/tests/master_maintenance_tests.cpp b42a81fc2e0982e8fca669bffb798c0acda684fc src/tests/master_quota_tests.cpp c2b46d23002481e63ff162e8628f9b974e3e8ef9 src/tests/master_slave_reconciliation_tests.cpp 988f1d46580ab5a707fe801824e24f94d4f50da7 src/tests/master_tests.cpp d34ba0bdd71efd261850d8c205c16cecb701ac7c src/tests/master_validation_tests.cpp 8d0070a1b8e8dcc7fe6360f8c6c6182ba9edef7d src/tests/mesos.hpp 93b9340d94d91663283fe5df5ad9febe69ffd2a3 src/tests/mesos.cpp 90aef6bfe619dc0acdb4ccba6a7180482dd13ce5 src/tests/metrics_tests.cpp 51b4515369b5a72cd9613bb87e7b9df9e1118e83 src/tests/monitor_tests.cpp 5dcb2481ff2f1a7caf54036bc3e60c78feb982b1 src/tests/oversubscription_tests.cpp ba036810758d99a6fb0034c5e2bc7829e2343a44 src/tests/partition_tests.cpp 349adbf67686e6044a2e6a4b673043ad74fce44e src/tests/persistent_volume_endpoints_tests.cpp d04063090e7f45b4c047a4e037eed1de79cd6958 src/tests/persistent_volume_tests.cpp 26fff19daa8b175fdcc06fd9467224d5920a1967 src/tests/rate_limiting_tests.cpp 5d68ac170cb5a948df1429ffbf8e5b8f02f708d9 src/tests/reconciliation_tests.cpp 5f541f5fe004ede943a1b022daab92f01d1f4853 src/tests/registrar_zookeeper_tests.cpp 45b687cf96438e2ea8cc94ab2147e2538763e702 src/tests/repair_tests.cpp f213ec94f4a3ecc5499983b1b36756f580b0543d src/tests/reservation_endpoints_tests.cpp 028e28c68e8a438d310df04fea0a7e54a6d642a3 src/tests/reservation_tests.cpp a9261bdf48c0af933e7fc303b7af356a60b49506 src/tests/resource_offers_tests.cpp 1cf292ee7931207596f8f06677386bef5965ef15 src/tests/role_tests.cpp 20ccca3ecdc53c65abd61190ef9f867c8e860578 src/tests/scheduler_driver_tests.cpp 824aa96106808f7e259fb755257034c89c997287 src/tests/scheduler_event_call_tests.cpp
Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/ --- (Updated March 17, 2016, 1:52 a.m.) Review request for mesos, Anand Mazumdar and Jie Yu. Changes --- Fix review request update issue in the last update. Bugs: MESOS-4954 https://issues.apache.org/jira/browse/MESOS-4954 Repository: mesos Description --- This fix changes the URL fetcher error message from LOG(ERROR) to LOG(INFO) as the plugin is actually skipped if it is not created. Diffs (updated) - src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 Diff: https://reviews.apache.org/r/44883/diff/ Testing --- make check (Ubuntu 14.04) Thanks, Yong Tang
Re: Review Request 44883: Fix the mis-leading URI fetcher error message (MESOS-4954).
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/44883/#review123829 --- Ship it! Ship It! - haosdent huang On March 16, 2016, 3:31 a.m., Yong Tang wrote: > > --- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/44883/ > --- > > (Updated March 16, 2016, 3:31 a.m.) > > > Review request for mesos and Anand Mazumdar. > > > Bugs: MESOS-4954 > https://issues.apache.org/jira/browse/MESOS-4954 > > > Repository: mesos > > > Description > --- > > This fix changes the URL fetcher error message from LOG(ERROR) > to LOG(INFO) as the plugin is actually skipped if it is not > created. > > > Diffs > - > > src/uri/fetcher.cpp 8645b66f6c64c76b6c02ef0b9827a7d694d5ba97 > > Diff: https://reviews.apache.org/r/44883/diff/ > > > Testing > --- > > make check (Ubuntu 14.04) > > > Thanks, > > Yong Tang > >
