Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review130005 --- Ship it! src/slave/http.cpp (line 680)

Re: Review Request 45014: Add /containers endpoint.

> On April 15, 2016, 12:33 a.m., Jie Yu wrote: > > ping? > > Jay Guo wrote: > bump sorry, was sick these days. WIll commit it today. - Jie --- This is an automatically generated e-mail. To reply, visit:

Re: Review Request 45014: Add /containers endpoint.

> On April 15, 2016, 12:33 a.m., Jie Yu wrote: > > ping? bump - Jay --- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review129045

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 18, 2016, 3:38 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review129045 --- ping? - Jie Yu On April 12, 2016, 9:11 a.m., Jay Guo wrote: >

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review128441 --- src/slave/http.cpp (line 669)

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 12, 2016, 9:11 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45014: Add /containers endpoint.

> On April 11, 2016, 8:31 p.m., Jie Yu wrote: > > src/slave/http.cpp, line 678 > > > > > > Why 'statisticsLimiter'? Let's not introduce the limiter for the > > `/containers` endpoint yet. I thought it's intended

Re: Review Request 45014: Add /containers endpoint.

> On April 11, 2016, 8:31 p.m., Jie Yu wrote: > > docs/endpoints/index.md, lines 106-109 > > > > > > Can you make the doc change a separate patch? Are you generating those > > endpoint docs using the script under

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 12, 2016, 8 a.m.) Review request for mesos and Jie Yu. Bugs:

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review128232 --- docs/endpoints/index.md

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 11, 2016, 4:28 p.m.) Review request for mesos and Jie Yu.

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review128070 --- Patch looks great! Reviews applied: [45014] Passed command:

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 11, 2016, 2:32 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45014: Add /containers endpoint.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/ --- (Updated April 11, 2016, 2:27 a.m.) Review request for mesos and Jie Yu.

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

> On March 22, 2016, 5:39 a.m., Jie Yu wrote: > > Instead of handling /containers endpoint in Slave, I would suggest we > > dispatch the request to ResourceMonitor. I will rename ResourceMonitor to > > ContainerMonitor, and we will be deprecating the /monitor/statistics > > endpoints in the

Re: Review Request 45014: Add /containers endpoint to return ResourceUsage.

--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45014/#review124783 --- Patch looks great! Reviews applied: [45014] Passed command: