Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

2016-03-21 Thread Jay Guo
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/ --- (Updated March 22, 2016, 3:34 a.m.) Review request for mesos, Joris Van

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

2016-03-21 Thread Jay Guo
> On March 21, 2016, 7:04 p.m., Benjamin Bannier wrote: > > src/master/master.hpp, line 546 > > > > > > Two things: > > > > (1) I think a more fitting name here might be `flags()` (cf `info()` > > just

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

2016-03-21 Thread Benjamin Bannier
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/#review124620 --- src/master/master.hpp (line 546)

Re: Review Request 45018: MESOS-3481 Add const accessor to Master flags.

2016-03-21 Thread Mesos ReviewBot
--- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/45018/#review124601 --- Patch looks great! Reviews applied: [45018] Passed command: