Re: Review Request 45037: Regenerated agent endpoint documentation.

2016-03-24 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45037/#review125235
---


Ship it!




Ship It!

- Adam B


On March 24, 2016, 2:07 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45037/
> ---
> 
> (Updated March 24, 2016, 2:07 a.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran the generate-endpoint-help.py scipt after adding the AUTHENTICATION 
> information to HELP.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/slave/api/v1/executor.md 
> 7fa7cdaeac1e9940fb9d8d6b58a96e360ad81b40 
>   docs/endpoints/slave/flags.md 44cbf1f3f99e9ce7af16a57d1391d24ceff7de5e 
>   docs/endpoints/slave/health.md db907e05e213a3710b5d6d9cd3c7ba1c9d959ee1 
>   docs/endpoints/slave/state.json.md b0bd1ada735c0b807b9184a1dba72576394f0218 
>   docs/endpoints/slave/state.md 3bab316872afdd79a3af79cd81ea3b7817b9bb38 
> 
> Diff: https://reviews.apache.org/r/45037/diff/
> 
> 
> Testing
> ---
> 
> Viewed rendered page via docker website  container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45037: Regenerated agent endpoint documentation.

2016-03-24 Thread Joerg Schad 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45037/
---

(Updated March 24, 2016, 9:07 a.m.)


Review request for mesos, Adam B and Greg Mann.


Changes
---

Regenerated.


Repository: mesos


Description
---

Reran the generate-endpoint-help.py scipt after adding the AUTHENTICATION 
information to HELP.


Diffs (updated)
-

  docs/endpoints/slave/api/v1/executor.md 
7fa7cdaeac1e9940fb9d8d6b58a96e360ad81b40 
  docs/endpoints/slave/flags.md 44cbf1f3f99e9ce7af16a57d1391d24ceff7de5e 
  docs/endpoints/slave/health.md db907e05e213a3710b5d6d9cd3c7ba1c9d959ee1 
  docs/endpoints/slave/state.json.md b0bd1ada735c0b807b9184a1dba72576394f0218 
  docs/endpoints/slave/state.md 3bab316872afdd79a3af79cd81ea3b7817b9bb38 

Diff: https://reviews.apache.org/r/45037/diff/


Testing
---

Viewed rendered page via docker website  container.


Thanks,

Joerg Schad

Re: Review Request 45037: Regenerated agent endpoint documentation.

2016-03-24 Thread Joerg Schad 


> On March 21, 2016, 10:30 a.m., Adam B wrote:
> > docs/endpoints/slave/health.md, lines 17-18
> > 
> >
> > Why the double-blank line here (and elsewhere)?

This is caused by the way the Description help is generated. We could change 
this, but I feel a) not an issue as it won't show up in the rendered help anb 
b) is not relevant to this review.
https://github.com/apache/mesos/commit/4209ad61c81a49f3e8f31689fccc20d0473878b6#diff-649de92701805e2ffac5604eef155befR59


- Joerg


---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45037/#review124526
---


On March 18, 2016, 4:53 p.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45037/
> ---
> 
> (Updated March 18, 2016, 4:53 p.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran the generate-endpoint-help.py scipt after adding the AUTHENTICATION 
> information to HELP.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/api/v1/scheduler.md 
> 7a75fd75eef458f26f9e5067b792329f310d5d24 
>   docs/endpoints/slave/api/v1/executor.md 
> 7fa7cdaeac1e9940fb9d8d6b58a96e360ad81b40 
>   docs/endpoints/slave/flags.md 44cbf1f3f99e9ce7af16a57d1391d24ceff7de5e 
>   docs/endpoints/slave/health.md db907e05e213a3710b5d6d9cd3c7ba1c9d959ee1 
>   docs/endpoints/slave/state.json.md b0bd1ada735c0b807b9184a1dba72576394f0218 
>   docs/endpoints/slave/state.md 3bab316872afdd79a3af79cd81ea3b7817b9bb38 
> 
> Diff: https://reviews.apache.org/r/45037/diff/
> 
> 
> Testing
> ---
> 
> Viewed rendered page via docker website  container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>

Re: Review Request 45037: Regenerated agent endpoint documentation.

2016-03-21 Thread Adam B 

---
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/45037/#review124526
---



I'd also like to see this re-run after we fix the bug in master's /flags 
endpoint doc.


docs/endpoints/slave/health.md (lines 17 - 18)


Why the double-blank line here (and elsewhere)?


- Adam B


On March 18, 2016, 9:53 a.m., Joerg Schad wrote:
> 
> ---
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/45037/
> ---
> 
> (Updated March 18, 2016, 9:53 a.m.)
> 
> 
> Review request for mesos, Adam B and Greg Mann.
> 
> 
> Repository: mesos
> 
> 
> Description
> ---
> 
> Reran the generate-endpoint-help.py scipt after adding the AUTHENTICATION 
> information to HELP.
> 
> 
> Diffs
> -
> 
>   docs/endpoints/master/api/v1/scheduler.md 
> 7a75fd75eef458f26f9e5067b792329f310d5d24 
>   docs/endpoints/slave/api/v1/executor.md 
> 7fa7cdaeac1e9940fb9d8d6b58a96e360ad81b40 
>   docs/endpoints/slave/flags.md 44cbf1f3f99e9ce7af16a57d1391d24ceff7de5e 
>   docs/endpoints/slave/health.md db907e05e213a3710b5d6d9cd3c7ba1c9d959ee1 
>   docs/endpoints/slave/state.json.md b0bd1ada735c0b807b9184a1dba72576394f0218 
>   docs/endpoints/slave/state.md 3bab316872afdd79a3af79cd81ea3b7817b9bb38 
> 
> Diff: https://reviews.apache.org/r/45037/diff/
> 
> 
> Testing
> ---
> 
> Viewed rendered page via docker website  container.
> 
> 
> Thanks,
> 
> Joerg Schad
> 
>